Bug 27496 - Accessibility: Navigation buttons are poorly described by screen readers
Summary: Accessibility: Navigation buttons are poorly described by screen readers
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kevin Carnes
QA Contact: Katrin Fischer
URL:
Keywords: accessibility
Depends on: 33813
Blocks: 23003
  Show dependency treegraph
 
Reported: 2021-01-20 10:56 UTC by Martin Renvoize
Modified: 2024-04-11 13:10 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers (3.60 KB, patch)
2023-08-18 12:19 UTC, Kevin Carnes
Details | Diff | Splinter Review
Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers (3.65 KB, patch)
2023-08-18 14:07 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers (3.71 KB, patch)
2023-08-25 12:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2021-01-20 10:56:45 UTC
Enable the ChromeVox screen reader for accessibility in your Chrome browser to test.

If you navigate through the site using the tab key then the 'Lists' button is  identified as 'Popup button collapsed', however, the next button, for languages when enabled, is identified as 'Button collapsed' and then the "Welcome user" button is identified as simply "Button".

All three of these buttons lead to a dropdown menu and should be consistently identified?
Comment 1 Kevin Carnes 2023-08-18 12:19:19 UTC
Created attachment 154650 [details] [review]
Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers

This patch adds aria-haspopup and aria-expanded attributes to the language
    and welcome user buttons so that screen readers will know that they cause a
    popup menu to be displayed.

    To test:
    1. Use an installation with at least 2 active languages
    2. Log in the OPAC
    3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to
       navigate to the language and welcome user buttons while noticing that
       they are described as "Button collapsed" and "Button", respectively
    4. Alternatively, inspect the buttons and notice that they are missing
       aria-haspopup and aria-expanded attributes
    5. Apply the patch
    6. Observe that these buttons now are described as "Popup button collapsed"
       or that they contain the aria-haspopup and aria-expanded attributes like
       the lists button
    7. Sign off
Comment 2 Lucas Gass 2023-08-18 14:07:11 UTC
Created attachment 154656 [details] [review]
Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers

This patch adds aria-haspopup and aria-expanded attributes to the language
    and welcome user buttons so that screen readers will know that they cause a
    popup menu to be displayed.

    To test:
    1. Use an installation with at least 2 active languages
    2. Log in the OPAC
    3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to
       navigate to the language and welcome user buttons while noticing that
       they are described as "Button collapsed" and "Button", respectively
    4. Alternatively, inspect the buttons and notice that they are missing
       aria-haspopup and aria-expanded attributes
    5. Apply the patch
    6. Observe that these buttons now are described as "Popup button collapsed"
       or that they contain the aria-haspopup and aria-expanded attributes like
       the lists button
    7. Sign off

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-08-25 12:53:50 UTC
Created attachment 154810 [details] [review]
Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers

This patch adds aria-haspopup and aria-expanded attributes to the language
    and welcome user buttons so that screen readers will know that they cause a
    popup menu to be displayed.

    To test:
    1. Use an installation with at least 2 active languages
    2. Log in the OPAC
    3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to
       navigate to the language and welcome user buttons while noticing that
       they are described as "Button collapsed" and "Button", respectively
    4. Alternatively, inspect the buttons and notice that they are missing
       aria-haspopup and aria-expanded attributes
    5. Apply the patch
    6. Observe that these buttons now are described as "Popup button collapsed"
       or that they contain the aria-haspopup and aria-expanded attributes like
       the lists button
    7. Sign off

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-08-29 17:36:02 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-30 06:34:36 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-08-31 10:12:02 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x