Enable the ChromeVox screen reader for accessibility in your Chrome browser to test. If you navigate through the site using the tab key then the 'Lists' button is identified as 'Popup button collapsed', however, the next button, for languages when enabled, is identified as 'Button collapsed' and then the "Welcome user" button is identified as simply "Button". All three of these buttons lead to a dropdown menu and should be consistently identified?
Created attachment 154650 [details] [review] Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers This patch adds aria-haspopup and aria-expanded attributes to the language and welcome user buttons so that screen readers will know that they cause a popup menu to be displayed. To test: 1. Use an installation with at least 2 active languages 2. Log in the OPAC 3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to navigate to the language and welcome user buttons while noticing that they are described as "Button collapsed" and "Button", respectively 4. Alternatively, inspect the buttons and notice that they are missing aria-haspopup and aria-expanded attributes 5. Apply the patch 6. Observe that these buttons now are described as "Popup button collapsed" or that they contain the aria-haspopup and aria-expanded attributes like the lists button 7. Sign off
Created attachment 154656 [details] [review] Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers This patch adds aria-haspopup and aria-expanded attributes to the language and welcome user buttons so that screen readers will know that they cause a popup menu to be displayed. To test: 1. Use an installation with at least 2 active languages 2. Log in the OPAC 3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to navigate to the language and welcome user buttons while noticing that they are described as "Button collapsed" and "Button", respectively 4. Alternatively, inspect the buttons and notice that they are missing aria-haspopup and aria-expanded attributes 5. Apply the patch 6. Observe that these buttons now are described as "Popup button collapsed" or that they contain the aria-haspopup and aria-expanded attributes like the lists button 7. Sign off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 154810 [details] [review] Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers This patch adds aria-haspopup and aria-expanded attributes to the language and welcome user buttons so that screen readers will know that they cause a popup menu to be displayed. To test: 1. Use an installation with at least 2 active languages 2. Log in the OPAC 3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to navigate to the language and welcome user buttons while noticing that they are described as "Button collapsed" and "Button", respectively 4. Alternatively, inspect the buttons and notice that they are missing aria-haspopup and aria-expanded attributes 5. Apply the patch 6. Observe that these buttons now are described as "Popup button collapsed" or that they contain the aria-haspopup and aria-expanded attributes like the lists button 7. Sign off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x