Summary: | Accessibility: More description required in OPAC search breadcrumbs | ||
---|---|---|---|
Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
Component: | OPAC | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 25243 | ||
Attachments: |
Bug 33819: Add page numbers to opac results breadcrumb
Bug 33819: Add page numbers to opac results breadcrumb Bug 33819: Add page numbers to opac results breadcrumb Bug 33819: Add page numbers to opac results breadcrumb |
Description
Matt Blenkinsop
2023-05-24 14:56:59 UTC
Created attachment 151637 [details] [review] Bug 33819: Add page numbers to opac results breadcrumb This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different. Created attachment 151693 [details] [review] Bug 33819: Add page numbers to opac results breadcrumb This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different. Signed-off-by: Owen Leonard <oleonard@myacpl.org> When there is no result: "Results of search for 'ezaze', page of " There are also missing space before the end of the TT tags [% current_page_number | html%] of [% pages | html%] Created attachment 154500 [details] [review] Bug 33819: Add page numbers to opac results breadcrumb This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different. To test: 1) Apply patch 2) Run a search in the OPAC that will return more than 20 results. 3) The breadcrumb should say "Results of search for 'search term', page x of y" 4) Run a search that will return less than 20 results 5) The breadcrumb should say "Results of search for 'search term' I am not entirely sure about the presentation. With a complicated search query it could get rather long and lost in the end. Maybe it could be a new 'part'/section of the breadcrumb? Home > Results of search for 'p', page 6 of 21 Could then be: Home > Results of search for 'p' > Page 6 of 21 I guess thinking hierarchies it would not be quite right... Also: we lost Owen's sign-off line in the rebase. I'll re-add it in QA. Created attachment 156682 [details] [review] Bug 33819: Add page numbers to opac results breadcrumb This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different. To test: 1) Apply patch 2) Run a search in the OPAC that will return more than 20 results. 3) The breadcrumb should say "Results of search for 'search term', page x of y" 4) Run a search that will return less than 20 results 5) The breadcrumb should say "Results of search for 'search term' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Nice small enhancement, I choose to backport. Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |