Summary: | Use filter_by_last_update in Koha::Notice::Util | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | 33837 | ||
Bug Blocks: | |||
Attachments: |
Bug 33843: Use filter_by_last_update in Koha::Notice::Util
Bug 33843: Use filter_by_last_update in Koha::Notice::Util Bug 33843: Use filter_by_last_update in Koha::Notice::Util Bug 33843: Use filter_by_last_update in Koha::Notice::Util Bug 33843: Use filter_by_last_update in Koha::Notice::Util |
Description
Marcel de Rooy
2023-05-26 08:19:19 UTC
Created attachment 151725 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new datetime parameter from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 153921 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new datetime parameter from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> OK Koha/Notice/Util.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid prove t/db_dependent/Koha/Notice_Util.t t/db_dependent/Koha/Notice_Util.t .. ok All tests successful. Files=1, Tests=4, 3 wallclock secs ( 0.04 usr 0.01 sys + 2.64 cusr 0.30 csys = 2.99 CPU) Result: PASS Created attachment 153922 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new logic from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 154432 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new logic from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Created attachment 155103 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new logic from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.11. Nice work everyone, thanks! |