Resolve FIXME in sub _get_domain_count by using new datetime parameter from bug 33837.
Created attachment 151725 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new datetime parameter from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 153921 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new datetime parameter from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
OK Koha/Notice/Util.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid prove t/db_dependent/Koha/Notice_Util.t t/db_dependent/Koha/Notice_Util.t .. ok All tests successful. Files=1, Tests=4, 3 wallclock secs ( 0.04 usr 0.01 sys + 2.64 cusr 0.30 csys = 2.99 CPU) Result: PASS
Created attachment 153922 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new logic from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 154432 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new logic from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 155103 [details] [review] Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new logic from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 33837 not in 23.05.x