Summary: | Vendor page does not manage existing field for accountnumber | ||
---|---|---|---|
Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | nengard, paul.poulain, wizzyrea |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 7267 | ||
Attachments: |
Bug 3388: Restore account number on vendor page
Bug 3388: Restore account number on vendor page |
Description
Chris Cormack
2010-05-21 01:09:55 UTC
I confirm this bug: there is no way to save an accountnumber in current master. The field aqbooksellers.accountnumber mediumtext still exists in the database, but there is no way to enter data. Created attachment 6093 [details] [review] Bug 3388: Restore account number on vendor page This patch makes it possible to add the account number to the vendor information. The used field aqbookseller.accountnumber was already existent in the database. To test: 1) Add a new vendor with accountnumber > Verify form has a field for accountnumber > Verify accountnumber does show up on vendor summary page 2) Edit this vendor, change accountnumber > Verify change was correctly saved and new number is displayed on vendor summary page 3) Delete accountnumber Created attachment 6102 [details] [review] Bug 3388: Restore account number on vendor page This patch makes it possible to add the account number to the vendor information. The used field aqbookseller.accountnumber was already existent in the database. To test: 1) Add a new vendor with accountnumber > Verify form has a field for accountnumber > Verify accountnumber does show up on vendor summary page 2) Edit this vendor, change accountnumber > Verify change was correctly saved and new number is displayed on vendor summary page 3) Delete accountnumber Signed-off-by: Liz Rea <lrea@nekls.org> Tested 1-3, no troubles found. Cleanly adds additional field to the necessary subroutines, as well as the interface. Cleans up some minor whitespace and spelling issues. Marking as Passed QA. i just tested this patch, it works as expected. Except the most important thing is missing: have the accountnumber displayed on the PDF generated: this number is usually requested by the bookseller. Am I missing something ? (not pushed yet until things are clear for me) Paul, can you push? The PDF should be dealt with in a separate patch. A lot of libraries don't use PDF printing at all. I think this can be a separate bug. |