Bug 3388 - Vendor page does not manage existing field for accountnumber
Summary: Vendor page does not manage existing field for accountnumber
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Katrin Fischer
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks: 7267
  Show dependency treegraph
 
Reported: 2009-07-02 07:50 UTC by Ian Walls
Modified: 2012-10-25 23:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 3388: Restore account number on vendor page (7.86 KB, patch)
2011-10-28 15:38 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 3388: Restore account number on vendor page (7.97 KB, patch)
2011-10-28 18:50 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:09:55 UTC


---- Reported by ian.walls@bywatersolutions.com 2009-07-02 19:50:34 ----

The staff client page /acqui/supplier.pl does not have a field to input a vendor's account number into the database (into aqbooksellers.accountnumber).  This is necessary for any kind of voucher export where the human-readable Company Name doesn't serve as a unique identifier.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:09 UTC  ---

This bug was previously known as _bug_ 3388 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3388

Unknown operating system Linux - Debian. Setting to default OS "All".
Actual time not defined. Setting to 0.0

Comment 1 Katrin Fischer 2011-08-15 18:53:56 UTC
I confirm this bug: there is no way to save an accountnumber in current master. 

The field aqbooksellers.accountnumber mediumtext still exists in the database, but there is no way to enter data.
Comment 2 Katrin Fischer 2011-10-28 15:38:09 UTC Comment hidden (obsolete)
Comment 3 Liz Rea 2011-10-28 18:50:18 UTC
Created attachment 6102 [details] [review]
Bug 3388: Restore account number on vendor page

This patch makes it possible to add the account number to the
vendor information. The used field aqbookseller.accountnumber was
already existent in the database.

To test:
1) Add a new vendor with accountnumber
> Verify form has a field for accountnumber
> Verify accountnumber does show up on vendor summary page
2) Edit this vendor, change accountnumber
> Verify change was correctly saved and new number is displayed on
vendor summary page
3) Delete accountnumber

Signed-off-by: Liz Rea <lrea@nekls.org>
Tested 1-3, no troubles found.
Comment 4 Ian Walls 2011-11-19 15:52:24 UTC
Cleanly adds additional field to the necessary subroutines, as well as the interface.  Cleans up some minor whitespace and spelling issues.  Marking as Passed QA.
Comment 5 Paul Poulain 2011-11-24 13:06:33 UTC
i just tested this patch, it works as expected. Except the most important thing is missing: have the accountnumber displayed on the PDF generated: this number is usually requested by the bookseller.

Am I missing something ?
(not pushed yet until things are clear for me)
Comment 6 Katrin Fischer 2011-11-24 13:18:16 UTC
Paul, can you push? The PDF should be dealt with in a separate patch. A lot of libraries don't use PDF printing at all. I think this can be a separate bug.
Comment 7 Paul Poulain 2011-11-25 11:18:37 UTC
Patch pushed, please test

Bug 7267 added to request displaying this number in the PDF as well