| Summary: | Overdues with fines report displays error 500 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Hector Gonzalez <cacho> |
| Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | david, dcook, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, Laura.escamilla, martin.renvoize |
| Version: | unspecified | Keywords: | rel_22_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the 'Circulation > Overdues > Overdues with fines' listing so that it lists overdue items where there are fines, instead of generating an error.
|
Version(s) released in: |
23.11.00,23.05.01,22.11.08
|
| Circulation function: | |||
| Bug Depends on: | 22375 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates
Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates |
||
|
Description
Hector Gonzalez
2023-06-02 18:40:57 UTC
Created attachment 152077 [details] [review] Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates Bug 22375 added use of KohaDates without the USE statement. Test plan: Make sure you have overdues and go to circ/branchoverdues.pl Without this patch you get a 500 Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127 With this patch applied you can see the overdue list No other occurrences apparently, the following command return only include files grep -l '$KohaDates' **/*.tt **/*.inc | xargs grep -L 'USE KohaDates' Ideally we should have the USE statement in include files as well, and add a test to catch those problems for KohaDates, raw, Price, etc. Created attachment 152085 [details] [review] Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates Bug 22375 added use of KohaDates without the USE statement. Test plan: Make sure you have overdues and go to circ/branchoverdues.pl Without this patch you get a 500 Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127 With this patch applied you can see the overdue list Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD):
1. To generate overdues with fines:
. set finesMode system preference to 'Calculate and charge'
. configure the Circulation and fine rules so that fines will be charged, I set:
. Fine amount: 5
. Fine charging interval: 2
. checkout some items to a patron - set the due date in the past
. run the misc/cronjobs/fines.pl script to calculate fines (I used fines.pl -v -m 10)
The patch fixes the problem in our servers, thank you! Created attachment 152202 [details] [review] Bug 33888: (bug 22375 follow-up) Add missing USE KohaDates Bug 22375 added use of KohaDates without the USE statement. Test plan: Make sure you have overdues and go to circ/branchoverdues.pl Without this patch you get a 500 Template process failed: undef error - : filter not found at /kohadevbox/koha/C4/Templates.pm line 127 With this patch applied you can see the overdue list Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Can this please be backported for next bugfix releas? No strings! (In reply to Katrin Fischer from comment #8) > Can this please be backported for next bugfix releas? No strings! I second Katrin, can this please be backported to 22.11.xx? Pushed to 23.05.x for 23.05.01 (In reply to Laura Escamilla from comment #9) > (In reply to Katrin Fischer from comment #8) > > Can this please be backported for next bugfix releas? No strings! > > > I second Katrin, can this please be backported to 22.11.xx? Indeed it is need for 22.11.x since it contains Bug 22375. Now that I have backported to 23.05 it will come down to 22.11.x (In reply to Fridolin Somers from comment #11) > (In reply to Laura Escamilla from comment #9) > > (In reply to Katrin Fischer from comment #8) > > > Can this please be backported for next bugfix releas? No strings! > > > > > > I second Katrin, can this please be backported to 22.11.xx? > > Indeed it is need for 22.11.x since it contains Bug 22375. > Now that I have backported to 23.05 it will come down to 22.11.x Doesn't look like it was part of v22.11.07. Does that mean it'll be part of v22.11.08 at the end of July? Yup, it'll make it to .08.. We'd already rolled .07 when this hit 23.05.01. Nice work everyone! Pushed to 22.11.x for next release |