Bug 22375 - Due dates should be formatted consistently
Summary: Due dates should be formatted consistently
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Keywords:
Depends on: 17236
Blocks: 33888
  Show dependency treegraph
 
Reported: 2019-02-20 12:26 UTC by Josef Moravec
Modified: 2023-06-15 18:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 22375: Format due date consistantly (8.13 KB, patch)
2019-02-20 12:48 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 22375: Format due date consistantly (7.82 KB, patch)
2023-04-16 01:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 22375: (follow-up) Format even more due dates consistently (11.74 KB, patch)
2023-04-16 01:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 22375: Format due date consistantly (7.90 KB, patch)
2023-05-04 13:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 22375: (follow-up) Format even more due dates consistently (11.76 KB, patch)
2023-05-04 13:11 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2019-02-20 12:26:54 UTC
Now we have some due dates formatted as datetime, and some shows time part only when it is hourly loan (as_due_date = 1 param of KohaDates filter is used)

This should be same for all due dates across whole system, as_due_date should be used everywhere
Comment 1 Josef Moravec 2019-02-20 12:48:22 UTC
Created attachment 85331 [details] [review]
Bug 22375: Format due date consistantly

Test plan:
Make some daily an hourly checkouts and confirm the right display
(hourly with hours and minutes, daily only date) of due date on these
places:
1) catalogue -> checkout history
2) circulation -> overdues with fines
3) batch checkouts
4) circulation -> pending on site checkouts
5) patrons circulation history
6) opac -> account summary ->  relatives checkouts

Note: I suspect the moremember-receipt.tt template is not used anymore
Comment 2 Owen Leonard 2019-07-31 18:19:08 UTC
(In reply to Josef Moravec from comment #1)

Everything looks like it's working well except this page:

> 3) batch checkouts

I get an error on that page.

> Note: I suspect the moremember-receipt.tt template is not used anymore

Yes, which is causing a conflict when apply this patch!
Comment 3 Katrin Fischer 2023-04-16 01:24:08 UTC
Created attachment 149722 [details] [review]
Bug 22375: Format due date consistantly

Test plan:
Make some daily an hourly checkouts and confirm the right display
(hourly with hours and minutes, daily only date) of due date on these
places:
1) catalogue -> checkout history
2) circulation -> overdues with fines
3) <already fixed>
4) circulation -> pending on site checkouts
5) patrons circulation history
6) opac -> account summary ->  relatives checkouts

Note: I suspect the moremember-receipt.tt template is not used anymore
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-04-16 01:24:10 UTC
Created attachment 149723 [details] [review]
Bug 22375: (follow-up) Format even more due dates consistently

To test:
Create some checkouts in future and past, make sure to include
some with a time != 23:59.CirculateILL

Verify that the due date is displayed correctly on:
* Catalog detail page > Items tab > Checkout status
* Circulation start page > Renew > Renew one of your checkouts > dialog message
* ILL request page: requires ILL setup and CirculateILL system preference
* Patron acccount in staff > Print > Print summary
* Catalog detail page > Holds > search for patron > due date on checked out items
* Recalls:
  * Activate UseRecalls system preference, set up circulation rules to allow recalls
  * Checkout an item to another user
  * In the OPAC, place a recall on that record with yor use
  * Check "Recall a specific item"
  * Verify due date in item list
  * Place recall on checked out item
  * Patron account in OPAC > Recalls history (due date might have been changed through recall)
* OPAC patron account > Summary > Overdue tab
* Self checkout:
  * Activate WebBasedSelfCheck
  * Go to <opacbaseurl>/cgi-bin/koha/sco/sco-main.pl
  * Log in > Tab checkouts

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-04-16 01:25:55 UTC
(In reply to Owen Leonard from comment #2)
> (In reply to Josef Moravec from comment #1)
> 
> Everything looks like it's working well except this page:
> 
> > 3) batch checkouts
> 
> I get an error on that page.

This file is no longer included in the patch set (already fixed).

> > Note: I suspect the moremember-receipt.tt template is not used anymore
> 
> Yes, which is causing a conflict when apply this patch!

This file has been deleted meanwhile and is also not included.

I found some more and wrote up a follow-up.
Comment 6 Jonathan Druart 2023-05-04 13:11:05 UTC
Created attachment 150655 [details] [review]
Bug 22375: Format due date consistantly

Test plan:
Make some daily an hourly checkouts and confirm the right display
(hourly with hours and minutes, daily only date) of due date on these
places:
1) catalogue -> checkout history
2) circulation -> overdues with fines
3) <already fixed>
4) circulation -> pending on site checkouts
5) patrons circulation history
6) opac -> account summary ->  relatives checkouts

Note: I suspect the moremember-receipt.tt template is not used anymore
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2023-05-04 13:11:08 UTC
Created attachment 150656 [details] [review]
Bug 22375: (follow-up) Format even more due dates consistently

To test:
Create some checkouts in future and past, make sure to include
some with a time != 23:59.CirculateILL

Verify that the due date is displayed correctly on:
* Catalog detail page > Items tab > Checkout status
* Circulation start page > Renew > Renew one of your checkouts > dialog message
* ILL request page: requires ILL setup and CirculateILL system preference
* Patron acccount in staff > Print > Print summary
* Catalog detail page > Holds > search for patron > due date on checked out items
* Recalls:
  * Activate UseRecalls system preference, set up circulation rules to allow recalls
  * Checkout an item to another user
  * In the OPAC, place a recall on that record with yor use
  * Check "Recall a specific item"
  * Verify due date in item list
  * Place recall on checked out item
  * Patron account in OPAC > Recalls history (due date might have been changed through recall)
* OPAC patron account > Summary > Overdue tab
* Self checkout:
  * Activate WebBasedSelfCheck
  * Go to <opacbaseurl>/cgi-bin/koha/sco/sco-main.pl
  * Log in > Tab checkouts

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

JD amended patch - removed 'fda'
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Katrin Fischer 2023-05-04 20:57:23 UTC
Thx, Jonathan :)
Comment 9 Tomás Cohen Arazi 2023-05-09 14:47:38 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Matt Blenkinsop 2023-05-15 12:21:09 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 11 Lucas Gass 2023-06-15 18:53:41 UTC
Merge conflicts in 22.05.x, no backport.