Bug 33891

Summary: Use template wrapper for tabs: OPAC advanced search
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: David Cook <dcook>
Severity: minor    
Priority: P5 - low CC: dcook, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.01,22.11.07
Bug Depends on:    
Bug Blocks: 32571, 33892, 33893, 33894, 33895, 33897    
Attachments: Bug 33891: Use template wrapper for tabs: OPAC advanced search
Bug 33891: Use template wrapper for tabs: OPAC advanced search
Bug 33891: Use template wrapper for tabs: OPAC advanced search

Description Owen Leonard 2023-06-05 12:40:37 UTC
Continuing the work of Bug 32571, I would like to update the OPAC advanced search page use the new WRAPPER for tabs
Comment 1 Owen Leonard 2023-06-05 12:50:41 UTC
Created attachment 151988 [details] [review]
Bug 33891: Use template wrapper for tabs: OPAC advanced search

This patch adds the tab WRAPPER markup to the OPAC, adapted for the
Bootstrap version used by the OPAC (4.5.0). The advanced search page is
updated to use the wrapper construction.

Unrelated markup fix: an empty size attribute is removed from an
<input>.

To test, apply the patch and view the the advanced search page in the
OPAC. The tabs for item type, shelving location, and collection should
all look correct and work correctly.

In the staff interface, go to Administration -> System preferences ->
OpacAdvancedSearchTypes and try various configurations, confirming each
time that the OPAC page adjustes correctly.
Comment 2 Lucas Gass 2023-06-05 22:24:20 UTC
Created attachment 152015 [details] [review]
Bug 33891: Use template wrapper for tabs: OPAC advanced search

This patch adds the tab WRAPPER markup to the OPAC, adapted for the
Bootstrap version used by the OPAC (4.5.0). The advanced search page is
updated to use the wrapper construction.

Unrelated markup fix: an empty size attribute is removed from an
<input>.

To test, apply the patch and view the the advanced search page in the
OPAC. The tabs for item type, shelving location, and collection should
all look correct and work correctly.

In the staff interface, go to Administration -> System preferences ->
OpacAdvancedSearchTypes and try various configurations, confirming each
time that the OPAC page adjustes correctly.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 David Cook 2023-06-06 06:08:06 UTC
Created attachment 152032 [details] [review]
Bug 33891: Use template wrapper for tabs: OPAC advanced search

This patch adds the tab WRAPPER markup to the OPAC, adapted for the
Bootstrap version used by the OPAC (4.5.0). The advanced search page is
updated to use the wrapper construction.

Unrelated markup fix: an empty size attribute is removed from an
<input>.

To test, apply the patch and view the the advanced search page in the
OPAC. The tabs for item type, shelving location, and collection should
all look correct and work correctly.

In the staff interface, go to Administration -> System preferences ->
OpacAdvancedSearchTypes and try various configurations, confirming each
time that the OPAC page adjustes correctly.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 4 Tomás Cohen Arazi 2023-06-06 13:01:35 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Tomás Cohen Arazi 2023-06-09 14:21:56 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-06-12 10:58:35 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x