Summary: | Use template wrapper for tabs: OPAC advanced search | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | David Cook <dcook> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dcook, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00,23.05.01,22.11.07
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 32571, 33892, 33893, 33894, 33895, 33897 | ||
Attachments: |
Bug 33891: Use template wrapper for tabs: OPAC advanced search
Bug 33891: Use template wrapper for tabs: OPAC advanced search Bug 33891: Use template wrapper for tabs: OPAC advanced search |
Description
Owen Leonard
2023-06-05 12:40:37 UTC
Created attachment 151988 [details] [review] Bug 33891: Use template wrapper for tabs: OPAC advanced search This patch adds the tab WRAPPER markup to the OPAC, adapted for the Bootstrap version used by the OPAC (4.5.0). The advanced search page is updated to use the wrapper construction. Unrelated markup fix: an empty size attribute is removed from an <input>. To test, apply the patch and view the the advanced search page in the OPAC. The tabs for item type, shelving location, and collection should all look correct and work correctly. In the staff interface, go to Administration -> System preferences -> OpacAdvancedSearchTypes and try various configurations, confirming each time that the OPAC page adjustes correctly. Created attachment 152015 [details] [review] Bug 33891: Use template wrapper for tabs: OPAC advanced search This patch adds the tab WRAPPER markup to the OPAC, adapted for the Bootstrap version used by the OPAC (4.5.0). The advanced search page is updated to use the wrapper construction. Unrelated markup fix: an empty size attribute is removed from an <input>. To test, apply the patch and view the the advanced search page in the OPAC. The tabs for item type, shelving location, and collection should all look correct and work correctly. In the staff interface, go to Administration -> System preferences -> OpacAdvancedSearchTypes and try various configurations, confirming each time that the OPAC page adjustes correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 152032 [details] [review] Bug 33891: Use template wrapper for tabs: OPAC advanced search This patch adds the tab WRAPPER markup to the OPAC, adapted for the Bootstrap version used by the OPAC (4.5.0). The advanced search page is updated to use the wrapper construction. Unrelated markup fix: an empty size attribute is removed from an <input>. To test, apply the patch and view the the advanced search page in the OPAC. The tabs for item type, shelving location, and collection should all look correct and work correctly. In the staff interface, go to Administration -> System preferences -> OpacAdvancedSearchTypes and try various configurations, confirming each time that the OPAC page adjustes correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to oldstable for 22.11.x |