Bug 33894 - Use template wrapper for tabs: OPAC search history
Summary: Use template wrapper for tabs: OPAC search history
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 33891
Blocks: 32571
  Show dependency treegraph
 
Reported: 2023-06-05 13:12 UTC by Owen Leonard
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections (26.73 KB, patch)
2023-06-05 15:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33894: Use template wrapper for tabs: OPAC search history (4.20 KB, patch)
2023-06-05 15:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections (26.78 KB, patch)
2023-06-06 00:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 33894: Use template wrapper for tabs: OPAC search history (4.25 KB, patch)
2023-06-06 00:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections (27.62 KB, patch)
2023-06-09 15:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33894: Use template wrapper for tabs: OPAC search history (4.25 KB, patch)
2023-06-09 15:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections (27.67 KB, patch)
2023-06-22 21:12 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33894: Use template wrapper for tabs: OPAC search history (4.31 KB, patch)
2023-06-22 21:12 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-05 13:12:37 UTC
Continuing the work of Bug 32571, I would like to update the OPAC search history page use the new WRAPPER for tabs
Comment 1 Owen Leonard 2023-06-05 15:31:11 UTC
Created attachment 152000 [details] [review]
Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections

In order to make the conversion to the tab wrapper markup easier I'm
putting the biblio search history and authority search history sections
into blocks. This will make it easier to include or not include the
sections using template logic.

To test, apply the patch and, if necessary, perform some searches for
bibliographic and authority records. The OPAC search history page should
be unchanged, with the correct information showing under each tab and in
each section for current and previous searches.
Comment 2 Owen Leonard 2023-06-05 15:31:13 UTC
Created attachment 152001 [details] [review]
Bug 33894: Use template wrapper for tabs: OPAC search history

This patch updates the OPAC search history page so that it uses
the new WRAPPER syntax to generate tabs markup.

To test, apply the patch and view the OPAC search history page. With the
OpacAuthorities system preference enabled you should see two tabs:
Catalog and Authority. Confirm that each tab shows the correct
information.

Deactivate OpacAuthorities and reload the search history page. The
bibliographic search history should display without tabs.
Comment 3 Owen Leonard 2023-06-05 15:47:12 UTC
Please note that the qa tool's errors about Font Awesome icons and aria-hidden attributes appears to be a false positive.
Comment 4 David Nind 2023-06-06 00:09:01 UTC Comment hidden (obsolete)
Comment 5 David Nind 2023-06-06 00:09:03 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2023-06-08 19:38:20 UTC
There is a conflict - can you please rebase?
Comment 7 Owen Leonard 2023-06-09 15:19:46 UTC
Created attachment 152255 [details] [review]
Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections

In order to make the conversion to the tab wrapper markup easier I'm
putting the biblio search history and authority search history sections
into blocks. This will make it easier to include or not include the
sections using template logic.

To test, apply the patch and, if necessary, perform some searches for
bibliographic and authority records. The OPAC search history page should
be unchanged, with the correct information showing under each tab and in
each section for current and previous searches.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Owen Leonard 2023-06-09 15:19:49 UTC
Created attachment 152256 [details] [review]
Bug 33894: Use template wrapper for tabs: OPAC search history

This patch updates the OPAC search history page so that it uses
the new WRAPPER syntax to generate tabs markup.

To test, apply the patch and view the OPAC search history page. With the
OpacAuthorities system preference enabled you should see two tabs:
Catalog and Authority. Confirm that each tab shows the correct
information.

Deactivate OpacAuthorities and reload the search history page. The
bibliographic search history should display without tabs.

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Katrin Fischer 2023-06-10 19:10:10 UTC
Hi Owen, 

could you check on these please?

 FAIL	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
   FAIL	  forbidden patterns
		forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166)  (line 117)
		forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166)  (line 164)
Comment 10 Owen Leonard 2023-06-12 10:55:23 UTC
(In reply to Owen Leonard from comment #3)
> Please note that the qa tool's errors about Font Awesome icons and
> aria-hidden attributes appears to be a false positive.

(I should have put this in the commit message!) The icons indicated by the QA tool do have aria-hidden attributes, so I'm not sure what's going on there.
Comment 11 Katrin Fischer 2023-06-22 21:12:45 UTC
Created attachment 152598 [details] [review]
Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections

In order to make the conversion to the tab wrapper markup easier I'm
putting the biblio search history and authority search history sections
into blocks. This will make it easier to include or not include the
sections using template logic.

To test, apply the patch and, if necessary, perform some searches for
bibliographic and authority records. The OPAC search history page should
be unchanged, with the correct information showing under each tab and in
each section for current and previous searches.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2023-06-22 21:12:47 UTC
Created attachment 152599 [details] [review]
Bug 33894: Use template wrapper for tabs: OPAC search history

This patch updates the OPAC search history page so that it uses
the new WRAPPER syntax to generate tabs markup.

To test, apply the patch and view the OPAC search history page. With the
OpacAuthorities system preference enabled you should see two tabs:
Catalog and Authority. Confirm that each tab shows the correct
information.

Deactivate OpacAuthorities and reload the search history page. The
bibliographic search history should display without tabs.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Tomás Cohen Arazi 2023-06-23 13:01:53 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Martin Renvoize 2023-07-17 14:02:56 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 15 Pedro Amorim 2023-07-18 11:54:33 UTC
Nice work everyone!

Pushed to 22.11.x for next release