Continuing the work of Bug 32571, I would like to update the OPAC search history page use the new WRAPPER for tabs
Created attachment 152000 [details] [review] Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches.
Created attachment 152001 [details] [review] Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs.
Please note that the qa tool's errors about Font Awesome icons and aria-hidden attributes appears to be a false positive.
Created attachment 152018 [details] [review] Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 152019 [details] [review] Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. Signed-off-by: David Nind <david@davidnind.com>
There is a conflict - can you please rebase?
Created attachment 152255 [details] [review] Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 152256 [details] [review] Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. Signed-off-by: David Nind <david@davidnind.com>
Hi Owen, could you check on these please? FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 117) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 164)
(In reply to Owen Leonard from comment #3) > Please note that the qa tool's errors about Font Awesome icons and > aria-hidden attributes appears to be a false positive. (I should have put this in the commit message!) The icons indicated by the QA tool do have aria-hidden attributes, so I'm not sure what's going on there.
Created attachment 152598 [details] [review] Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 152599 [details] [review] Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to 22.11.x for next release