Bug 33917

Summary: Improve translation of title tags: Offline circulation and patron lists
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 33906    
Attachments: Bug 33917: Improve translation of title tags: Offline circulation and patron lists
Bug 33917: Improve translation of title tags: Offline circulation and patron lists
Bug 33917: Improve translation of title tags: Offline circulation and patron lists
Bug 33917: Improve translation of title tags: Offline circulation and patron lists

Description Owen Leonard 2023-06-06 16:01:32 UTC
This patch will modify offline circulation templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-06-13 17:17:48 UTC
Patron lists templates will also be included in this update
Comment 2 Owen Leonard 2023-06-13 17:23:05 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2023-08-18 08:15:29 UTC
Created attachment 154594 [details] [review]
Bug 33917: Improve translation of title tags: Offline circulation and patron lists

This patch updates offline circulation and patron lists templates so
that title tags can be more easily translated.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Circulation -> Upload offline circulation file
  - Add to queue
  - View pending offline circulations
- Tools -> Patron lists
  - New list, edit list
  - View list
Comment 4 Chris Cormack 2023-08-18 09:43:40 UTC
Created attachment 154628 [details] [review]
Bug 33917: Improve translation of title tags: Offline circulation and patron lists

This patch updates offline circulation and patron lists templates so
that title tags can be more easily translated.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Circulation -> Upload offline circulation file
  - Add to queue
  - View pending offline circulations
- Tools -> Patron lists
  - New list, edit list
  - View list

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 5 Jonathan Druart 2023-09-01 09:42:07 UTC
Created attachment 155088 [details] [review]
Bug 33917: Improve translation of title tags: Offline circulation and patron lists

This patch updates offline circulation and patron lists templates so
that title tags can be more easily translated.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Circulation -> Upload offline circulation file
  - Add to queue
  - View pending offline circulations
- Tools -> Patron lists
  - New list, edit list
  - View list

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-09-01 14:24:33 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-09-08 05:54:03 UTC
Not backported to 23.05.x