Summary: | Move GetAllIssues to Koha | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, fridolin.somers, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | 33948, 33949 | ||
Bug Blocks: | 16846 | ||
Attachments: |
Bug 33947: Remove GetAllIssues
Bug 33947: Remove GetAllIssues Bug 33947: Remove GetAllIssues Bug 33947: Remove GetAllIssues Bug 33947: Remove GetAllIssues |
Description
Jonathan Druart
2023-06-08 07:46:06 UTC
Created attachment 152156 [details] [review] Bug 33947: Remove GetAllIssues No more occurrences of GetAllIssues, remove it! Test plan: git grep is your friend All dependent patches applied on https://gitlab.com/joubu/Koha/-/commits/bug_33947 Created attachment 152195 [details] [review] Bug 33947: Remove GetAllIssues No more occurrences of GetAllIssues, remove it! Test plan: git grep is your friend Patch no longer applies 8-(.. Bug 33947 - Move GetAllIssues to Koha 152195 - Bug 33947: Remove GetAllIssues Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33947: Remove GetAllIssues Using index info to reconstruct a base tree... M C4/Members.pm M t/db_dependent/Members/GetAllIssues.t Falling back to patching base and 3-way merge... CONFLICT (modify/delete): t/db_dependent/Members/GetAllIssues.t deleted in Bug 33947: Remove GetAllIssues and modified in HEAD. Version HEAD of t/db_dependent/Members/GetAllIssues.t left in tree. Auto-merging C4/Members.pm CONFLICT (content): Merge conflict in C4/Members.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 33947: Remove GetAllIssues Created attachment 156444 [details] [review] Bug 33947: Remove GetAllIssues No more occurrences of GetAllIssues, remove it! Test plan: git grep is your friend Created attachment 156445 [details] [review] Bug 33947: Remove GetAllIssues No more occurrences of GetAllIssues, remove it! Test plan: git grep is your friend Signed-off-by: David Nind <david@davidnind.com> Created attachment 156959 [details] [review] Bug 33947: Remove GetAllIssues No more occurrences of GetAllIssues, remove it! Test plan: git grep is your friend Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |