Created attachment 152155 [details] [review] Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings
Created attachment 152177 [details] [review] Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings
Created attachment 155781 [details] [review] Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings
Created attachment 155782 [details] [review] Bug 33949: Fix display of old checkouts if no checkouts exist If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in.
Created attachment 156440 [details] [review] Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings Signed-off-by: David Nind <david@davidnind.com>
Created attachment 156441 [details] [review] Bug 33949: Fix display of old checkouts if no checkouts exist If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in. Signed-off-by: David Nind <david@davidnind.com>
I've signed off, but I had a couple of questions: 1. I'm not sure where I should be checking for the display of the ISBN and UPC numbers. (I added a UPC code for a record (024$a with 1 and 0 in the indicators)). 2. Old checkouts - I was sure how to replicate this issue. After applying the patch, checking out and checking in an item, things displayed as expected. This worked the same before the patches were applied. Testing notes (using KTD): 1. I added several checkouts for a patron and checked some items in. 2. I added some ratings in the OPAC for items displayed in the history. 3. Enabled a couple of the cover image services - Amazon, OpenLibrary, and local cover images. 4. After apply the patches, I noticed no differences in the display in the OPAC for the patron's Checkout history (including 'Show all items') and their Summary. 5. I noticed that local cover images are not displayed in the checkout history and summary pages - bug 32514 has already been created for this.
(In reply to David Nind from comment #7) > I've signed off, but I had a couple of questions: Thanks! > 1. I'm not sure where I should be checking for the display of the ISBN and > UPC numbers. (I added a UPC code for a record (024$a with 1 and 0 in the > indicators)). Sorry, wrong test plan. The UPC is used by BakerTaylor, and the ISBN for the cover images. They are not directly displayed on the UI. > 2. Old checkouts - I was sure how to replicate this issue. After applying > the patch, checking out and checking in an item, things displayed as > expected. This worked the same before the patches were applied. Yes, the second patch is a follow-up for the first patch. It's no fixing a bug that is in master.
Thanks Jonathan!
Created attachment 156957 [details] [review] Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 156958 [details] [review] Bug 33949: Fix display of old checkouts if no checkouts exist If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x