Bug 33948

*** Bug 8483 has been marked as a duplicate of this bug. ***

Created attachment 152154 [details] [review]
Bug 33948: Replace GetAllIssues with Koha::Checkouts - staff

This patch replace GetAllIssues in readingrec.pl which is the only
occurrence in the staff code.

To test this patch you will need several items in your checkout history
in order to confirm that the display is the same before and after the
patch.

However there is one change! And it's a bug fix (or an enhancement, it
depends on how you see things). It includes checkouts with deleted items, which is
a long standing bug (see bug 8483).

Performance will be compared as well.

Created attachment 154005 [details] [review]
Bug 33948: Replace GetAllIssues with Koha::Checkouts - staff

This patch replace GetAllIssues in readingrec.pl which is the only
occurrence in the staff code.

To test this patch you will need several items in your checkout history
in order to confirm that the display is the same before and after the
patch.

However there is one change! And it's a bug fix (or an enhancement, it
depends on how you see things). It includes checkouts with deleted items, which is
a long standing bug (see bug 8483).

Performance will be compared as well.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

I fixed on missing space before $KohaDates : 
[% checkout.returndate |$KohaDates with_hours => 1 %]

Performance looks OK.

Created attachment 156091 [details] [review]
Bug 33948: Replace GetAllIssues with Koha::Checkouts - staff

This patch replace GetAllIssues in readingrec.pl which is the only
occurrence in the staff code.

To test this patch you will need several items in your checkout history
in order to confirm that the display is the same before and after the
patch.

However there is one change! And it's a bug fix (or an enhancement, it
depends on how you see things). It includes checkouts with deleted items, which is
a long standing bug (see bug 8483).

Performance will be compared as well.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Pushed to master for 23.11.

Nice work everyone, thanks!

Enhancement not pushed to 23.05.x

koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt

                                <td><a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% issue.issuer_id | uri %]">[% issue.firstname | html %] [% issue.surname | html %]</a></td>

changed to:

                                [% SET issuer = checkout.issuer %]
                                <td><a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% issuer.issuer_id | uri %]">[% issuer.firstname | html %] [% issuer.surname | html %]</a></td>

that leads to error:

    Koha::Patron->issuer_id is not covered by tests!

should be:


    issuer.borrowernumber

I suppose.

Created a ticket where the fix for this problem will be provided ->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335

(In reply to Andrii Nugged from comment #8)
> koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
> 
>                                 <td><a
> href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% issue.issuer_id |
> uri %]">[% issue.firstname | html %] [% issue.surname | html %]</a></td>
> 
> changed to:
> 
>                                 [% SET issuer = checkout.issuer %]
>                                 <td><a
> href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% issuer.issuer_id |
> uri %]">[% issuer.firstname | html %] [% issuer.surname | html %]</a></td>
> 
> that leads to error:
> 
>     Koha::Patron->issuer_id is not covered by tests!
> 
> should be:
> 
> 
>     issuer.borrowernumber
> 
> I suppose.

Yes, can you provide a fix?