| Summary: | "Update and run SQL" for non-English templates | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Reports | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | andreas.jonsson, fridolin.somers, jonathan.druart, nugged, pedro.amorim |
| Version: | Main | Keywords: | rel_23_05_candidate |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.01
|
|
| Circulation function: | |||
| Bug Depends on: | 23824 | ||
| Bug Blocks: | 35936 | ||
| Attachments: |
Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates
Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates |
||
|
Description
Katrin Fischer
2023-06-08 21:47:02 UTC
self-quoting from 23824#c18 ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824#c18 ) You can not save the report editing form in non-English interfaces anymore. I.e., this breaks how "Update" (saving form) works: in non-English Koha button's text becomes translated, what is desired for UI, but not for code, but the hidden "non-translated" value was removed: <input type="hidden" name="phase" value="Update SQL" /> And, if the button's content is translated, it doesn't matches the comparison in reports/guided_reports.pl to the "phase" parameter with hardcoded "Update SQL". Somebody working on this? Created attachment 152248 [details] [review] Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates This patch should work, I haven't tested it however. I solved that on production before in templates only :), <input type="submit" onclick="this.value='Update SQL'" name="phase" class="btn btn-primary" value="Update SQL" /> <input type="submit" onclick="this.value='Update and run SQL'" name="phase" class="btn btn-primary" value="Update and run SQL" /> in a hacky way, :facepalm: but now I will build our custom .deb with your patch, Jonathan, install on production, and sign-off. Created attachment 152267 [details] [review] Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 152274 [details] [review] Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrii Nugged <nugged@gmail.com> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.01 Missing dependencies for 22.11.x. Not pushing. |