|
Description
Aleisha Amohia
2023-06-15 03:25:43 UTC
Created attachment 152371 [details] [review] Bug 34016: Tests for fulfilling recalls via SIP Created attachment 152372 [details] [review] Bug 34016: [WIP] Working on fulfilling recalls via SIP Created attachment 152396 [details] [review] Bug 34016: Tests for fulfilling recalls via SIP Created attachment 152397 [details] [review] Bug 34016: [WIP] Working on fulfilling recalls via SIP Created attachment 152458 [details] [review] Bug 34016: Manage recalls via SIP This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron. To test: 1. Run test `prove t/db_dependent/SIP/Transaction.t` 2. Confirm the test fails when trying to fulfill the recall 3. Apply the patch and restart services 4. Run test again `prove t/db_dependent/SIP/Transaction.t` 5. Confirm tests pass Sponsored-by: Auckland University of Technology Created attachment 152461 [details] [review] Bug 34016: Tests for fulfilling recalls via SIP Signed-off-by: David Nind <david@davidnind.com> Created attachment 152462 [details] [review] Bug 34016: Manage recalls via SIP This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron. To test: 1. Run test `prove t/db_dependent/SIP/Transaction.t` 2. Confirm the test fails when trying to fulfill the recall 3. Apply the patch and restart services 4. Run test again `prove t/db_dependent/SIP/Transaction.t` 5. Confirm tests pass Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. I applied the first patch ==> tests failed. 2. After applying the second patch (plus a flush_memcached, and restart-all). the tests pass. Looking here Not talking about:
WARN t/db_dependent/SIP/Transaction.t
WARN tidiness
The file is less tidy than before (bad/messy lines before: 256, now: 280)
Created attachment 155382 [details] [review] Bug 34016: Tests for fulfilling recalls via SIP Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 155383 [details] [review] Bug 34016: Manage recalls via SIP This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron. To test: 1. Run test `prove t/db_dependent/SIP/Transaction.t` 2. Confirm the test fails when trying to fulfill the recall 3. Apply the patch and restart services 4. Run test again `prove t/db_dependent/SIP/Transaction.t` 5. Confirm tests pass Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 155471 [details] [review] Bug 34016: (QA follow-up) perltidy fixes (In reply to Marcel de Rooy from comment #10) > Not talking about: > > WARN t/db_dependent/SIP/Transaction.t > WARN tidiness > The file is less tidy than before (bad/messy lines before: > 256, now: 280) May as well not introduce untidiness! Have fixed in QA follow-up Rebased on top of (already pushed) bug 32496. Created attachment 156154 [details] [review] Bug 34016: Tests for fulfilling recalls via SIP Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 156155 [details] [review] Bug 34016: Manage recalls via SIP This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron. To test: 1. Run test `prove t/db_dependent/SIP/Transaction.t` 2. Confirm the test fails when trying to fulfill the recall 3. Apply the patch and restart services 4. Run test again `prove t/db_dependent/SIP/Transaction.t` 5. Confirm tests pass Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.11. Nice work everyone, thanks! Depends on Bug 32496 not in 23.05.x |