Bug 34016 - Enable fulfillment of recalled items through SIP2
Summary: Enable fulfillment of recalled items through SIP2
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Aleisha Amohia
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 19532 32496
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-15 03:25 UTC by Aleisha Amohia
Modified: 2024-12-23 08:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement allows SIP (using a self-check machines) to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron.
Version(s) released in:
23.11.00
Circulation function:


Attachments
Bug 34016: Tests for fulfilling recalls via SIP (4.51 KB, patch)
2023-06-15 05:22 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34016: [WIP] Working on fulfilling recalls via SIP (2.71 KB, patch)
2023-06-15 05:22 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34016: Tests for fulfilling recalls via SIP (4.56 KB, patch)
2023-06-16 03:26 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34016: [WIP] Working on fulfilling recalls via SIP (2.71 KB, patch)
2023-06-16 03:26 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34016: Manage recalls via SIP (3.20 KB, patch)
2023-06-19 03:06 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34016: Tests for fulfilling recalls via SIP (4.61 KB, patch)
2023-06-19 06:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 34016: Manage recalls via SIP (3.24 KB, patch)
2023-06-19 06:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 34016: Tests for fulfilling recalls via SIP (4.70 KB, patch)
2023-09-08 09:39 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34016: Manage recalls via SIP (3.34 KB, patch)
2023-09-08 09:39 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34016: (QA follow-up) perltidy fixes (5.16 KB, patch)
2023-09-10 22:12 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 34016: Tests for fulfilling recalls via SIP (4.75 KB, patch)
2023-09-25 12:52 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 34016: Manage recalls via SIP (3.37 KB, patch)
2023-09-25 12:52 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2023-06-15 03:25:43 UTC
Currently items that have been recalled are not fulfilled properly when they're checked out using SIP2 (i..e a self-check machine). 

The item is successfully checked out but the recall request is not filled and closed.
Comment 1 Aleisha Amohia 2023-06-15 05:22:04 UTC
Created attachment 152371 [details] [review]
Bug 34016: Tests for fulfilling recalls via SIP
Comment 2 Aleisha Amohia 2023-06-15 05:22:07 UTC
Created attachment 152372 [details] [review]
Bug 34016: [WIP] Working on fulfilling recalls via SIP
Comment 3 Aleisha Amohia 2023-06-16 03:26:55 UTC
Created attachment 152396 [details] [review]
Bug 34016: Tests for fulfilling recalls via SIP
Comment 4 Aleisha Amohia 2023-06-16 03:26:58 UTC
Created attachment 152397 [details] [review]
Bug 34016: [WIP] Working on fulfilling recalls via SIP
Comment 5 Aleisha Amohia 2023-06-19 03:06:40 UTC
Created attachment 152458 [details] [review]
Bug 34016: Manage recalls via SIP

This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron.

To test:

1. Run test `prove t/db_dependent/SIP/Transaction.t`
2. Confirm the test fails when trying to fulfill the recall
3. Apply the patch and restart services
4. Run test again `prove t/db_dependent/SIP/Transaction.t`
5. Confirm tests pass

Sponsored-by: Auckland University of Technology
Comment 6 David Nind 2023-06-19 06:41:29 UTC
Created attachment 152461 [details] [review]
Bug 34016: Tests for fulfilling recalls via SIP

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-06-19 06:41:31 UTC
Created attachment 152462 [details] [review]
Bug 34016: Manage recalls via SIP

This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron.

To test:

1. Run test `prove t/db_dependent/SIP/Transaction.t`
2. Confirm the test fails when trying to fulfill the recall
3. Apply the patch and restart services
4. Run test again `prove t/db_dependent/SIP/Transaction.t`
5. Confirm tests pass

Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2023-06-19 06:44:53 UTC
Testing notes (using KTD):

1. I applied the first patch ==> tests failed.

2. After applying the second patch (plus a flush_memcached, and restart-all). the tests pass.
Comment 9 Marcel de Rooy 2023-09-08 09:30:24 UTC
Looking here
Comment 10 Marcel de Rooy 2023-09-08 09:32:14 UTC
Not talking about:

 WARN   t/db_dependent/SIP/Transaction.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 256, now: 280)
Comment 11 Marcel de Rooy 2023-09-08 09:39:05 UTC
Created attachment 155382 [details] [review]
Bug 34016: Tests for fulfilling recalls via SIP

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 12 Marcel de Rooy 2023-09-08 09:39:08 UTC
Created attachment 155383 [details] [review]
Bug 34016: Manage recalls via SIP

This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron.

To test:

1. Run test `prove t/db_dependent/SIP/Transaction.t`
2. Confirm the test fails when trying to fulfill the recall
3. Apply the patch and restart services
4. Run test again `prove t/db_dependent/SIP/Transaction.t`
5. Confirm tests pass

Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 13 Aleisha Amohia 2023-09-10 22:12:59 UTC
Created attachment 155471 [details] [review]
Bug 34016: (QA follow-up) perltidy fixes
Comment 14 Aleisha Amohia 2023-09-10 22:13:26 UTC
(In reply to Marcel de Rooy from comment #10)
> Not talking about:
> 
>  WARN   t/db_dependent/SIP/Transaction.t
>    WARN   tidiness
>                 The file is less tidy than before (bad/messy lines before:
> 256, now: 280)

May as well not introduce untidiness! Have fixed in QA follow-up
Comment 15 Tomás Cohen Arazi (tcohen) 2023-09-25 12:51:55 UTC
Rebased on top of (already pushed) bug 32496.
Comment 16 Tomás Cohen Arazi (tcohen) 2023-09-25 12:52:33 UTC
Created attachment 156154 [details] [review]
Bug 34016: Tests for fulfilling recalls via SIP

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 17 Tomás Cohen Arazi (tcohen) 2023-09-25 12:52:37 UTC
Created attachment 156155 [details] [review]
Bug 34016: Manage recalls via SIP

This enhancement allows SIP to better handle recalled items - preventing the check-out of recalled items if they have been allocated to another patron, or fulfilling recalls if the item was recalled and allocated to this patron.

To test:

1. Run test `prove t/db_dependent/SIP/Transaction.t`
2. Confirm the test fails when trying to fulfill the recall
3. Apply the patch and restart services
4. Run test again `prove t/db_dependent/SIP/Transaction.t`
5. Confirm tests pass

Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 18 Tomás Cohen Arazi (tcohen) 2023-09-25 13:49:30 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 19 Fridolin Somers 2023-09-25 19:05:14 UTC
Depends on Bug 32496 not in 23.05.x