| Summary: | Move various translatable strings out of opac-bottom.inc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 21156, 34026 | ||
| Bug Blocks: | 34034 | ||
| Attachments: |
Bug 34031: Move various translatable strings out of opac-bottom.inc
Bug 34031: Move various translatable strings out of opac-bottom.inc Bug 34031: Move various translatable strings out of opac-bottom.inc Bug 34031: Move various translatable strings out of opac-bottom.inc |
||
|
Description
Owen Leonard
2023-06-16 11:19:13 UTC
Created attachment 152402 [details] [review] Bug 34031: Move various translatable strings out of opac-bottom.inc This patch moves some JS variable definitions out of opac-bottom.inc. These variables where defined so that they could be picked up for translation, but they can now be moved to the corresponding <script> blocks. Many other of these variables are not used at all and have been removed. To test you should have EnableOpacSearchHistory, OPACPrivacy, and opacreadinghistory enabled. Apply the patch and log into the OPAC as a user with suggestions, search history, and checkout history. - Click your user menu at the top of the page and click the "Clear" link for search history. You should see a confirmation, "Are you sure you want to delete your search history?" Confirming should trigger your search history deletion. - From your user summary page, click "Privacy." Under "Immediate deletion," clicking any of the delete buttons should trigger a confirmation, "Warning: Cannot be undone. Please confirm once again" - From your user summary page, click "Purchase suggestions." - Without checking any checkbox, click the "Delete selected" button at the bottom. You should see an alert, "No suggestion was selected." Created attachment 155205 [details] [review] Bug 34031: Move various translatable strings out of opac-bottom.inc This patch moves some JS variable definitions out of opac-bottom.inc. These variables where defined so that they could be picked up for translation, but they can now be moved to the corresponding <script> blocks. Many other of these variables are not used at all and have been removed. To test you should have EnableOpacSearchHistory, OPACPrivacy, and opacreadinghistory enabled. Apply the patch and log into the OPAC as a user with suggestions, search history, and checkout history. - Click your user menu at the top of the page and click the "Clear" link for search history. You should see a confirmation, "Are you sure you want to delete your search history?" Confirming should trigger your search history deletion. - From your user summary page, click "Privacy." Under "Immediate deletion," clicking any of the delete buttons should trigger a confirmation, "Warning: Cannot be undone. Please confirm once again" - From your user summary page, click "Purchase suggestions." - Without checking any checkbox, click the "Delete selected" button at the bottom. You should see an alert, "No suggestion was selected." Signed-off-by: David Nind <david@davidnind.com> Created attachment 155896 [details] [review] Bug 34031: Move various translatable strings out of opac-bottom.inc This patch moves some JS variable definitions out of opac-bottom.inc. These variables where defined so that they could be picked up for translation, but they can now be moved to the corresponding <script> blocks. Many other of these variables are not used at all and have been removed. To test you should have EnableOpacSearchHistory, OPACPrivacy, and opacreadinghistory enabled. Apply the patch and log into the OPAC as a user with suggestions, search history, and checkout history. - Click your user menu at the top of the page and click the "Clear" link for search history. You should see a confirmation, "Are you sure you want to delete your search history?" Confirming should trigger your search history deletion. - From your user summary page, click "Privacy." Under "Immediate deletion," clicking any of the delete buttons should trigger a confirmation, "Warning: Cannot be undone. Please confirm once again" - From your user summary page, click "Purchase suggestions." - Without checking any checkbox, click the "Delete selected" button at the bottom. You should see an alert, "No suggestion was selected." Signed-off-by: David Nind <david@davidnind.com> We need a sign-off on the dependency here, please! Created attachment 156708 [details] [review] Bug 34031: Move various translatable strings out of opac-bottom.inc This patch moves some JS variable definitions out of opac-bottom.inc. These variables where defined so that they could be picked up for translation, but they can now be moved to the corresponding <script> blocks. Many other of these variables are not used at all and have been removed. To test you should have EnableOpacSearchHistory, OPACPrivacy, and opacreadinghistory enabled. Apply the patch and log into the OPAC as a user with suggestions, search history, and checkout history. - Click your user menu at the top of the page and click the "Clear" link for search history. You should see a confirmation, "Are you sure you want to delete your search history?" Confirming should trigger your search history deletion. - From your user summary page, click "Privacy." Under "Immediate deletion," clicking any of the delete buttons should trigger a confirmation, "Warning: Cannot be undone. Please confirm once again" - From your user summary page, click "Purchase suggestions." - Without checking any checkbox, click the "Delete selected" button at the bottom. You should see an alert, "No suggestion was selected." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |