A few strings are defined in opac-bottom.inc for use by OverDrive and OpenLibrary search integration. These can be moved to the corresponding <script> block.
Created attachment 152411 [details] [review] Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary This patch removes some string variable definitions from opac-bottom.inc. The strings can now be picked up for translation from the corresponding <script> block. To test you must enable OpenLibrarySearch and enter OverDrive credentials to enable OverDrive search integration. - Perform a search in the OPAC. - As the results page loads you should see at the top "Searching OverDrive..." and "Searching OpenLibrary..." - When the searches complete you should see "Found X results in the library's Y collection" for each service. - Try to trigger an error message by entering the wrong (non-zero) value for the OverDriveLibraryID preference. - The search results page should show "Error searching OverDrive collection"
Created attachment 155240 [details] [review] Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary This patch removes some string variable definitions from opac-bottom.inc. The strings can now be picked up for translation from the corresponding <script> block. To test you must enable OpenLibrarySearch and enter OverDrive credentials to enable OverDrive search integration. - Perform a search in the OPAC. - As the results page loads you should see at the top "Searching OverDrive..." and "Searching OpenLibrary..." - When the searches complete you should see "Found X results in the library's Y collection" for each service. - Try to trigger an error message by entering the wrong (non-zero) value for the OverDriveLibraryID preference. - The search results page should show "Error searching OverDrive collection" Signed-off-by: David Nind <david@davidnind.com>
I've signed off, even though I don't have any OverDrive credentials. I was able to trigger the error message by entering some random details for OverDrive credentials. Please change back to needs signoff if this insufficient.
We need a sign-off on one of the dependencies here, please!
(In reply to Katrin Fischer from comment #4) > We need a sign-off on one of the dependencies here, please! I've signed off all the related dependencies and changed the status to 'Signed off' where required (hope that is the right thing to do - bug 34035, bug 34031, bug 34026, and bug 33983).
Created attachment 156709 [details] [review] Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary This patch removes some string variable definitions from opac-bottom.inc. The strings can now be picked up for translation from the corresponding <script> block. To test you must enable OpenLibrarySearch and enter OverDrive credentials to enable OverDrive search integration. - Perform a search in the OPAC. - As the results page loads you should see at the top "Searching OverDrive..." and "Searching OpenLibrary..." - When the searches complete you should see "Found X results in the library's Y collection" for each service. - Try to trigger an error message by entering the wrong (non-zero) value for the OverDriveLibraryID preference. - The search results page should show "Error searching OverDrive collection" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x