Bug 34034

Summary: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: david, fridolin.somers, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on: 21156, 34031    
Bug Blocks: 34035    
Attachments: Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary
Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary
Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary

Description Owen Leonard 2023-06-16 12:47:24 UTC
A few strings are defined in opac-bottom.inc for use by OverDrive and OpenLibrary search integration. These can be moved to the corresponding <script> block.
Comment 1 Owen Leonard 2023-06-16 13:01:34 UTC
Created attachment 152411 [details] [review]
Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary

This patch removes some string variable definitions from
opac-bottom.inc. The strings can now be picked up for translation from
the corresponding <script> block.

To test you must enable OpenLibrarySearch and enter OverDrive
credentials to enable OverDrive search integration.

- Perform a search in the OPAC.
- As the results page loads you should see at the top "Searching
  OverDrive..." and "Searching OpenLibrary..."
- When the searches complete you should see "Found X results in the
  library's Y collection" for each service.
- Try to trigger an error message by entering the wrong (non-zero) value
  for the OverDriveLibraryID preference.
- The search results page should show "Error searching OverDrive
  collection"
Comment 2 David Nind 2023-09-05 21:32:29 UTC
Created attachment 155240 [details] [review]
Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary

This patch removes some string variable definitions from
opac-bottom.inc. The strings can now be picked up for translation from
the corresponding <script> block.

To test you must enable OpenLibrarySearch and enter OverDrive
credentials to enable OverDrive search integration.

- Perform a search in the OPAC.
- As the results page loads you should see at the top "Searching
  OverDrive..." and "Searching OpenLibrary..."
- When the searches complete you should see "Found X results in the
  library's Y collection" for each service.
- Try to trigger an error message by entering the wrong (non-zero) value
  for the OverDriveLibraryID preference.
- The search results page should show "Error searching OverDrive
  collection"

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-09-05 21:34:28 UTC
I've signed off, even though I don't have any OverDrive credentials.

I was able to trigger the error message by entering some random details for OverDrive credentials.

Please change back to needs signoff if this insufficient.
Comment 4 Katrin Fischer 2023-10-07 15:02:40 UTC
We need a sign-off on one of the dependencies here, please!
Comment 5 David Nind 2023-10-07 21:36:40 UTC
(In reply to Katrin Fischer from comment #4)
> We need a sign-off on one of the dependencies here, please!

I've signed off all the related dependencies and changed the status to 'Signed off' where required (hope that is the right thing to do - bug 34035, bug 34031, bug 34026, and bug 33983).
Comment 6 Katrin Fischer 2023-10-08 14:10:42 UTC
Created attachment 156709 [details] [review]
Bug 34034: Move translatable strings out of opac-bottom.inc: OverDrive and OpenLibrary

This patch removes some string variable definitions from
opac-bottom.inc. The strings can now be picked up for translation from
the corresponding <script> block.

To test you must enable OpenLibrarySearch and enter OverDrive
credentials to enable OverDrive search integration.

- Perform a search in the OPAC.
- As the results page loads you should see at the top "Searching
  OverDrive..." and "Searching OpenLibrary..."
- When the searches complete you should see "Found X results in the
  library's Y collection" for each service.
- Try to trigger an error message by entering the wrong (non-zero) value
  for the OverDriveLibraryID preference.
- The search results page should show "Error searching OverDrive
  collection"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-10-09 14:42:46 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-10-09 18:43:00 UTC
Enhancement not pushed to 23.05.x