Bug 34185

Summary:	Code mixes OpacItemLocation and OPACItemLocation
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	System Administration	Assignee:	Laura Escamilla <Laura.escamilla>
Status:	RESOLVED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	gmcharlt, Laura.escamilla, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00
Circulation function:
Attachments:	Bug 34185: Capitalized OPAC in OpacItemLocation syspref Bug 34185: Capitalized OPAC in OpacItemLocation syspref

Description Katrin Fischer 2023-07-01 16:31:13 UTC

We have some OpacItemLocation and some OPACItemLocation in the code. Usually not a great idea. Would be nice to clean that up.

Comment 1 Laura Escamilla 2024-08-30 16:58:52 UTC

Created attachment 170920 [details] [review]
Bug 34185: Capitalized OPAC in OpacItemLocation syspref

To test:
1. In K-T-D git grep for “OpacItemLocation”
    1. Notice that related XSLT / XSL scripts are not coming up. Only .pm, .pl and .sql scripts.
2. Git grep for “OPACItemLocation”. Note that XSLT/XSL files show up but not the .pm, .pl and .sql scripts.
3. Apply the patch. Updatedatabase. Restart_all
4. Git grep for “OPACItemLocation”
    1. Notice that both the XSLT/XSL files in addition to the .sql, .pm and .pl scripts are now showing up.
5. Sign off and have a spectacular day :D

Comment 2 Roman Dolny 2024-08-30 18:27:08 UTC

Created attachment 170925 [details] [review]
Bug 34185: Capitalized OPAC in OpacItemLocation syspref

To test:
1. In K-T-D git grep for “OpacItemLocation”
    1. Notice that related XSLT / XSL scripts are not coming up. Only .pm, .pl and .sql scripts.
2. Git grep for “OPACItemLocation”. Note that XSLT/XSL files show up but not the .pm, .pl and .sql scripts.
3. Apply the patch. Updatedatabase. Restart_all
4. Git grep for “OPACItemLocation”
    1. Notice that both the XSLT/XSL files in addition to the .sql, .pm and .pl scripts are now showing up.
5. Sign off and have a spectacular day :D

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Comment 3 Katrin Fischer 2024-09-02 08:45:40 UTC

Hi Laura, 

I see that you have this step in your test plan:

3. Apply the patch. Updatedatabase. Restart_all

But your patch doesn't include a database update. 

I think it might be nice to update the existing installations with the correct spelling, what do you think?

Comment 4 Katrin Fischer 2024-09-02 10:22:04 UTC

I need to get better about removing tested patches from my branch... could you please provide the database update as a follow-up?

Comment 5 Katrin Fischer 2024-11-14 15:21:45 UTC

(In reply to Katrin Fischer from comment #4)
> I need to get better about removing tested patches from my branch... could
> you please provide the database update as a follow-up?

Dropping this. It can be resolved later, but I believe it does not actually cause issues.