We have some OpacItemLocation and some OPACItemLocation in the code. Usually not a great idea. Would be nice to clean that up.
Created attachment 170920 [details] [review] Bug 34185: Capitalized OPAC in OpacItemLocation syspref To test: 1. In K-T-D git grep for “OpacItemLocation” 1. Notice that related XSLT / XSL scripts are not coming up. Only .pm, .pl and .sql scripts. 2. Git grep for “OPACItemLocation”. Note that XSLT/XSL files show up but not the .pm, .pl and .sql scripts. 3. Apply the patch. Updatedatabase. Restart_all 4. Git grep for “OPACItemLocation” 1. Notice that both the XSLT/XSL files in addition to the .sql, .pm and .pl scripts are now showing up. 5. Sign off and have a spectacular day :D
Created attachment 170925 [details] [review] Bug 34185: Capitalized OPAC in OpacItemLocation syspref To test: 1. In K-T-D git grep for “OpacItemLocation” 1. Notice that related XSLT / XSL scripts are not coming up. Only .pm, .pl and .sql scripts. 2. Git grep for “OPACItemLocation”. Note that XSLT/XSL files show up but not the .pm, .pl and .sql scripts. 3. Apply the patch. Updatedatabase. Restart_all 4. Git grep for “OPACItemLocation” 1. Notice that both the XSLT/XSL files in addition to the .sql, .pm and .pl scripts are now showing up. 5. Sign off and have a spectacular day :D Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Hi Laura, I see that you have this step in your test plan: 3. Apply the patch. Updatedatabase. Restart_all But your patch doesn't include a database update. I think it might be nice to update the existing installations with the correct spelling, what do you think?
I need to get better about removing tested patches from my branch... could you please provide the database update as a follow-up?
(In reply to Katrin Fischer from comment #4) > I need to get better about removing tested patches from my branch... could > you please provide the database update as a follow-up? Dropping this. It can be resolved later, but I believe it does not actually cause issues.