Summary: | Toolbar component should make the icon configurable | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | ERM | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | alexander.blanchard, jonathan.druart, jonathan.field, martin.renvoize, matt.blenkinsop, pedro.amorim |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
Circulation function: | |||
Bug Depends on: | 33417 | ||
Bug Blocks: | 34215 | ||
Attachments: |
Bug 34214: Make 'icon' configurable for Toolbar options
Bug 34214: Make 'icon' configurable for Toolbar options Bug 34214: Make 'icon' configurable for Toolbar options |
Description
Jonathan Druart
2023-07-06 07:17:52 UTC
Created attachment 153083 [details] [review] Bug 34214: Make 'icon' configurable for Toolbar options Bug 33417 added a generic 'Toolbar' Vue component but always add a 'plus' icon. We should make it configurable. Test plan: Regenerate the Vue app: `yarn js:build` Go to the ERM module and confirm that the toolbar has the '+' icon. Sponsored-by: BULAC - http://www.bulac.fr/ Created attachment 153149 [details] [review] Bug 34214: Make 'icon' configurable for Toolbar options Bug 33417 added a generic 'Toolbar' Vue component but always add a 'plus' icon. We should make it configurable. Test plan: Regenerate the Vue app: `yarn js:build` Go to the ERM module and confirm that the toolbar has the '+' icon. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com> Created attachment 153153 [details] [review] Bug 34214: Make 'icon' configurable for Toolbar options Bug 33417 added a generic 'Toolbar' Vue component but always add a 'plus' icon. We should make it configurable. Test plan: Regenerate the Vue app: `yarn js:build` Go to the ERM module and confirm that the toolbar has the '+' icon. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |