Bug 34230

Summary: Add part_name and part_number to subscription result list
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: SerialsAssignee: Katrin Fischer <katrin.fischer>
Status: Needs documenting --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, lucas, michaela.sieber
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34199
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
**Sponsored by** *The Research University in the Helmholtz Association (KIT)*
Version(s) released in:
23.11.00
Attachments: k
Bug 34230: Add part_name and part_number to subscription search results
Bug 34230: Add part_name and part_number to subscription search results
Bug 34230: Add part_name and part_number to subscription search results
Bug 34230: Add part_name and part_number to subscription search results

Description Katrin Fischer 2023-07-07 16:09:54 UTC
We added the subtitle to the subscription results, but as series often have similar names and are hard to distinguish, it would be great if part_name and part_number would also be shown to help to identify the correct entries (245$n and $p in MARC21).
Comment 1 Katrin Fischer 2023-07-07 16:13:28 UTC
Created attachment 153189 [details] [review]
k
Comment 2 Katrin Fischer 2023-07-07 16:14:37 UTC
Created attachment 153191 [details] [review]
Bug 34230: Add part_name and part_number to subscription search results

This adds biblio.part_name and biblio.part_number to the SELECT of
SearchSubscriptions in order to be able to display the information in
the results list. It does not affect search.

To test:
* Add one or more subscriptions
* Make sure at least one is linked to a title with 245$abnp
* Verify that the result list only shows 245$ab
* Apply patch
* Verify full title information is now shown
Comment 3 Katrin Fischer 2023-07-07 16:15:45 UTC
I looked at the existing unit tests for SearchSubscriptions and right now we don't verify the return values at all, just checking that an ARRAY is returned. I was not sure how to extend that if deemed necessary. Pointers welcome.
Comment 4 Sam Lau 2023-07-07 16:41:49 UTC
Created attachment 153195 [details] [review]
Bug 34230: Add part_name and part_number to subscription search results

This adds biblio.part_name and biblio.part_number to the SELECT of
SearchSubscriptions in order to be able to display the information in
the results list. It does not affect search.

To test:
* Add one or more subscriptions
* Make sure at least one is linked to a title with 245$abnp
* Verify that the result list only shows 245$ab
* Apply patch
* Verify full title information is now shown

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 5 ByWater Sandboxes 2023-07-08 10:27:11 UTC
Created attachment 153207 [details] [review]
Bug 34230: Add part_name and part_number to subscription search results

This adds biblio.part_name and biblio.part_number to the SELECT of
SearchSubscriptions in order to be able to display the information in
the results list. It does not affect search.

To test:
* Add one or more subscriptions
* Make sure at least one is linked to a title with 245$abnp
* Verify that the result list only shows 245$ab
* Apply patch
* Verify full title information is now shown

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 6 Chris Cormack 2023-09-21 21:19:55 UTC
Created attachment 156016 [details] [review]
Bug 34230: Add part_name and part_number to subscription search results

This adds biblio.part_name and biblio.part_number to the SELECT of
SearchSubscriptions in order to be able to display the information in
the results list. It does not affect search.

To test:
* Add one or more subscriptions
* Make sure at least one is linked to a title with 245$abnp
* Verify that the result list only shows 245$ab
* Apply patch
* Verify full title information is now shown

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 7 Tomás Cohen Arazi 2023-09-22 14:34:55 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-09-22 19:46:31 UTC
Enhancement not pushed to 23.05.x