We added the subtitle to the subscription results, but as series often have similar names and are hard to distinguish, it would be great if part_name and part_number would also be shown to help to identify the correct entries (245$n and $p in MARC21).
Created attachment 153189 [details] [review] k
Created attachment 153191 [details] [review] Bug 34230: Add part_name and part_number to subscription search results This adds biblio.part_name and biblio.part_number to the SELECT of SearchSubscriptions in order to be able to display the information in the results list. It does not affect search. To test: * Add one or more subscriptions * Make sure at least one is linked to a title with 245$abnp * Verify that the result list only shows 245$ab * Apply patch * Verify full title information is now shown
I looked at the existing unit tests for SearchSubscriptions and right now we don't verify the return values at all, just checking that an ARRAY is returned. I was not sure how to extend that if deemed necessary. Pointers welcome.
Created attachment 153195 [details] [review] Bug 34230: Add part_name and part_number to subscription search results This adds biblio.part_name and biblio.part_number to the SELECT of SearchSubscriptions in order to be able to display the information in the results list. It does not affect search. To test: * Add one or more subscriptions * Make sure at least one is linked to a title with 245$abnp * Verify that the result list only shows 245$ab * Apply patch * Verify full title information is now shown Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 153207 [details] [review] Bug 34230: Add part_name and part_number to subscription search results This adds biblio.part_name and biblio.part_number to the SELECT of SearchSubscriptions in order to be able to display the information in the results list. It does not affect search. To test: * Add one or more subscriptions * Make sure at least one is linked to a title with 245$abnp * Verify that the result list only shows 245$ab * Apply patch * Verify full title information is now shown Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 156016 [details] [review] Bug 34230: Add part_name and part_number to subscription search results This adds biblio.part_name and biblio.part_number to the SELECT of SearchSubscriptions in order to be able to display the information in the results list. It does not affect search. To test: * Add one or more subscriptions * Make sure at least one is linked to a title with 245$abnp * Verify that the result list only shows 245$ab * Apply patch * Verify full title information is now shown Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x
Nothing to add or edit in the manual as far as I can see.