| Summary: | Checkin and renewal error messages disappear immediately in checkouts table | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27249 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | 28653 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 34302: DO NOT PUSH - to test failure
Bug 34302: (bug 28653 follow-up) Do not refresh the table if an error happened Bug 34302: (bug 28653 follow-up) Do not refresh the table if an error happened Bug 34302: (bug 28653 follow-up) Do not refresh the table if an error happened |
||
|
Description
Julian Maurice
2023-07-18 10:34:35 UTC
Thx for filing, Julian. I noticed the other day, it also prevents the success messages for reneals and checkins from being visible to the user. Created attachment 153969 [details] [review] Bug 34302: DO NOT PUSH - to test failure Really, do not push! :D Created attachment 153970 [details] [review] Bug 34302: (bug 28653 follow-up) Do not refresh the table if an error happened If checkin or renew failed, we should not refresh the table or it will hide the error message. Test plan: Apply the DO NOT PUSH patch Do a renew => No error in the table Apply this patch Do a renew => You see the error Revert the DO NOT PUSH patch Do a renew => The table is refreshed Created attachment 155251 [details] [review] Bug 34302: (bug 28653 follow-up) Do not refresh the table if an error happened If checkin or renew failed, we should not refresh the table or it will hide the error message. Test plan: Apply the DO NOT PUSH patch Do a renew => No error in the table Apply this patch Do a renew => You see the error Revert the DO NOT PUSH patch Do a renew => The table is refreshed Signed-off-by: David Cook <dcook@prosentient.com.au> Weird, I don't get the error. I also tried with "Always show checkouts automatically" ticked and I don't see the difference when doing renewals with just the "the DO NOT PUSH patch" and both patches. Services have been restarted after patch applications. Should the error be in the checkout list? I only get the yellow message about confirming renewal on the top of the page. Created attachment 155910 [details] [review] Bug 34302: (bug 28653 follow-up) Do not refresh the table if an error happened If checkin or renew failed, we should not refresh the table or it will hide the error message. Test plan: Apply the DO NOT PUSH patch Do a renew => No error in the table Apply this patch Do a renew => You see the error Revert the DO NOT PUSH patch Do a renew => The table is refreshed Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I believe this might only be a partial fix. We have still lost the success messages. (In reply to Katrin Fischer from comment #7) > I believe this might only be a partial fix. We have still lost the success > messages. This is much more complicated... Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |