Summary: | 'Item(s)' in MARC detail view untranslatable | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.03,22.11.09
|
|
Bug Depends on: | 33185 | ||
Bug Blocks: | |||
Attachments: |
Bug 34334: Item(s) in MARCdetail untranslatable
Bug 34334: Item(s) in MARCdetail untranslatable Bug 34334: Item(s) in MARCdetail untranslatable |
Description
Caroline Cyr La Rose
2023-07-20 20:52:18 UTC
I tried adding a span tag around the word in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt (line 146), but it's still not picking it up... Created attachment 153775 [details] [review] Bug 34334: Item(s) in MARCdetail untranslatable This patch adds a <span> around the text "Item(s)" in the template for the MARC detail page in the staff interface. Without the span the translation tool can't detect the string. To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the string is now in the .po file for translation. You should find these lines: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt:146 c-format msgid "Item(s)" msgstr "Exemplaire(s)" I found that the translation was already populated. Install the updated po file: > perl translate install fr-FR Test the MARC detail page in your translated language to confirm that the string is correct. (In reply to Caroline Cyr La Rose from comment #1) > I tried adding a span tag around the word in > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt (line 146), > but it's still not picking it up... It worked for me! Give it a try and let me know if you're not getting the same result. Created attachment 153794 [details] [review] Bug 34334: Item(s) in MARCdetail untranslatable This patch adds a <span> around the text "Item(s)" in the template for the MARC detail page in the staff interface. Without the span the translation tool can't detect the string. To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the string is now in the .po file for translation. You should find these lines: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt:146 c-format msgid "Item(s)" msgstr "Exemplaire(s)" I found that the translation was already populated. Install the updated po file: > perl translate install fr-FR Test the MARC detail page in your translated language to confirm that the string is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 153795 [details] [review] Bug 34334: Item(s) in MARCdetail untranslatable This patch adds a <span> around the text "Item(s)" in the template for the MARC detail page in the staff interface. Without the span the translation tool can't detect the string. To test, apply the patch and update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file, in this case misc/translator/po/fr-FR-staff-prog.po - Confirm that the string is now in the .po file for translation. You should find these lines: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt:146 c-format msgid "Item(s)" msgstr "Exemplaire(s)" I found that the translation was already populated. Install the updated po file: > perl translate install fr-FR Test the MARC detail page in your translated language to confirm that the string is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Thank you Owen! I'm stumped as to why it didn't work for me yesterday. My working hypothesis right now is that I was too tired and probably mangled the commands to translate. :) Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.03 Nice work everyone! Pushed to 22.11.x for next release Missing 22.05.x dependencies. No backport. |