Summary: | Revert Bug 34072: Holds queue search interface hidden on small screens | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, kyle.m.hall, lucas, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.10
|
|
Circulation function: | |||
Bug Depends on: | 34072 | ||
Bug Blocks: | |||
Attachments: |
Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens
Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens |
Description
Owen Leonard
2023-07-21 13:55:47 UTC
Created attachment 154651 [details] [review] Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored. Created attachment 154655 [details] [review] Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 154754 [details] [review] Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |