Bug 34343

Summary: Z39.50 search background not updated
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: fridolin.somers
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09
Circulation function:
Bug Depends on: 30952    
Bug Blocks: 35362, 35363, 35364, 34453, 34553, 34562, 34566, 35350, 35857    
Attachments: Bug 34343: Update style of fixed footer navbar in Z39.50 searches
Bug 34343: Update style of fixed footer navbar in Z39.50 searches
Bug 34343: Update style of fixed footer navbar in Z39.50 searches

Description Caroline Cyr La Rose 2023-07-21 19:25:58 UTC
There is a blue gradient in the background of the Z39.50 search window pop-up. I think it is a relic from the old staff interface design...

To get there:
1. In the staff interface, go to Cataloging
2. Click New from Z39.50/SRU
--> At the bottom of the pop-up window, the background is a blue gradient
Comment 1 Owen Leonard 2023-07-24 10:51:03 UTC Comment hidden (obsolete)
Comment 2 Caroline Cyr La Rose 2023-07-26 15:55:54 UTC
I don't have the language footer in the pop-up window. Is it normal?

Otherwise everything is A-OK!
Comment 3 Owen Leonard 2023-07-26 23:47:47 UTC
(In reply to Caroline Cyr La Rose from comment #2)
> I don't have the language footer in the pop-up window. Is it normal?

Yes we don't typically show the language menu footer in pop-up windows.
Comment 4 Caroline Cyr La Rose 2023-07-27 13:07:34 UTC Comment hidden (obsolete)
Comment 5 Caroline Cyr La Rose 2023-07-27 13:08:15 UTC
Thanks Owen!
Comment 6 Katrin Fischer 2023-07-29 17:26:28 UTC
Created attachment 154054 [details] [review]
Bug 34343: Update style of fixed footer navbar in Z39.50 searches

We use a Bootstrap fixed navbar in the footer of two pages: the popup
Z39.50 searches in cataloging and authorities. The style of these
footers needs to be udpated for the new staff interface design.

This patch also changes the style of the "cancel" controls in these
footers from links to buttons. The popup window in cataloging has been
adjusted to be the same size as the one in authorities.

To test, apply the batch and rebuild the staff interface CSS.

- Go to Cataloging -> New from Z39.50/SRU.
  - In the popup window, the form should fit comfortably in the window.
  - The footer should be white with a grey border at the top, with
    Bootstrap-styled buttons aligned to the right.
- Perform the same test in Authorities -> New from Z39.50/SRU
- Install and enable an additional translation so that you can confirm
  that the language-selection footer still has the correct style.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi (tcohen) 2023-08-15 12:20:13 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-08-17 20:23:35 UTC
Pushed to 23.05.x for 23.05.03
Comment 9 Pedro Amorim 2023-08-18 13:51:18 UTC
Nice work everyone!

Pushed to 22.11.x for next release
Comment 10 Owen Leonard 2023-09-29 11:58:00 UTC
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.