I would like to update several serial module pop-up windows to be consistent with Bug 34343 and its children: - serials/acqui-search-result.tt - serials/acqui-search.tt - serials/result.tt - serials/subscription-bib-search.tt - serials/routing-preview-slip.tt - serials/subscription-renew.tt
Created attachment 159110 [details] [review] Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up.
Created attachment 159720 [details] [review] Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 163715 [details] [review] Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 163901 [details] [review] Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 165228 [details] [review] Bug 35364: Update serials pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x