| Summary: | Improve layout of curbside pickups items ready list | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 30650 | ||
| Bug Blocks: | |||
| Attachments: |
Screenshot showing the misaligned title list
Bug 34373: Improve layout of curbside pickups items ready list Bug 34373: Improve layout of curbside pickups items ready list Bug 34373: Improve layout of curbside pickups items ready list |
||
Created attachment 153884 [details] [review] Bug 34373: Improve layout of curbside pickups items ready list This patch adds fieldset + list markup around the list of titles ready for pickup on the staff interface curbside pickup page. - Properly testing requires testing data. You can run this command to REPLACE your curbside pickup data with sample data: bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh) - Apply the patch and restart services. - Place multiple holds for a single patron and check them in to mark them waiting. - Under Circulation -> Curbside pickups, click the "Schedule pickup" tab. - Search for the patron you placed the holds for. - When the patron information comes up, the list of items ready for pickup should be well-formatted. Created attachment 153893 [details] [review] Bug 34373: Improve layout of curbside pickups items ready list This patch adds fieldset + list markup around the list of titles ready for pickup on the staff interface curbside pickup page. - Properly testing requires testing data. You can run this command to REPLACE your curbside pickup data with sample data: bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh) - Apply the patch and restart services. - Place multiple holds for a single patron and check them in to mark them waiting. - Under Circulation -> Curbside pickups, click the "Schedule pickup" tab. - Search for the patron you placed the holds for. - When the patron information comes up, the list of items ready for pickup should be well-formatted. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 155074 [details] [review] Bug 34373: Improve layout of curbside pickups items ready list This patch adds fieldset + list markup around the list of titles ready for pickup on the staff interface curbside pickup page. - Properly testing requires testing data. You can run this command to REPLACE your curbside pickup data with sample data: bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh) - Apply the patch and restart services. - Place multiple holds for a single patron and check them in to mark them waiting. - Under Circulation -> Curbside pickups, click the "Schedule pickup" tab. - Search for the patron you placed the holds for. - When the patron information comes up, the list of items ready for pickup should be well-formatted. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thanks, Owen! Pushed to master for 23.11. Nice work everyone, thanks! Not backported to 23.05.x |
Created attachment 153883 [details] Screenshot showing the misaligned title list When scheduling a curbside pickup, the list of items ready for pickup is not formatted well. The list of titles should align with input fields in the form.