Bug 34373 - Improve layout of curbside pickups items ready list
Summary: Improve layout of curbside pickups items ready list
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30650
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-25 14:28 UTC by Owen Leonard
Modified: 2023-09-19 12:20 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Screenshot showing the misaligned title list (36.49 KB, image/png)
2023-07-25 14:28 UTC, Owen Leonard
Details
Bug 34373: Improve layout of curbside pickups items ready list (3.94 KB, patch)
2023-07-25 15:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34373: Improve layout of curbside pickups items ready list (4.00 KB, patch)
2023-07-25 22:57 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34373: Improve layout of curbside pickups items ready list (4.07 KB, patch)
2023-09-01 09:13 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-25 14:28:41 UTC
Created attachment 153883 [details]
Screenshot showing the misaligned title list

When scheduling a curbside pickup, the list of items ready for pickup is not formatted well. The list of titles should align with input fields in the form.
Comment 1 Owen Leonard 2023-07-25 15:07:52 UTC
Created attachment 153884 [details] [review]
Bug 34373: Improve layout of curbside pickups items ready list

This patch adds fieldset + list markup around the list of titles ready
for pickup on the staff interface curbside pickup page.

- Properly testing requires testing data. You can run this command to
  REPLACE your curbside pickup data with sample data:

  bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh)
- Apply the patch and restart services.
- Place multiple holds for a single patron and check them in to mark
  them waiting.
- Under Circulation -> Curbside pickups, click the "Schedule pickup"
  tab.
  - Search for the patron you placed the holds for.
  - When the patron information comes up, the list of items ready for
    pickup should be well-formatted.
Comment 2 Lucas Gass 2023-07-25 22:57:53 UTC
Created attachment 153893 [details] [review]
Bug 34373: Improve layout of curbside pickups items ready list

This patch adds fieldset + list markup around the list of titles ready
for pickup on the staff interface curbside pickup page.

- Properly testing requires testing data. You can run this command to
  REPLACE your curbside pickup data with sample data:

  bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh)
- Apply the patch and restart services.
- Place multiple holds for a single patron and check them in to mark
  them waiting.
- Under Circulation -> Curbside pickups, click the "Schedule pickup"
  tab.
  - Search for the patron you placed the holds for.
  - When the patron information comes up, the list of items ready for
    pickup should be well-formatted.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2023-09-01 09:13:47 UTC
Created attachment 155074 [details] [review]
Bug 34373: Improve layout of curbside pickups items ready list

This patch adds fieldset + list markup around the list of titles ready
for pickup on the staff interface curbside pickup page.

- Properly testing requires testing data. You can run this command to
  REPLACE your curbside pickup data with sample data:

  bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh)
- Apply the patch and restart services.
- Place multiple holds for a single patron and check them in to mark
  them waiting.
- Under Circulation -> Curbside pickups, click the "Schedule pickup"
  tab.
  - Search for the patron you placed the holds for.
  - When the patron information comes up, the list of items ready for
    pickup should be well-formatted.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-09-01 09:13:57 UTC
Thanks, Owen!
Comment 5 Tomás Cohen Arazi 2023-09-01 14:44:50 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 05:58:22 UTC
Not backported to 23.05.x