Bug 34393

Summary:	Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	david, fridolin.somers
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This fixes some inconsistencies in the MARC bibliographic framework administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other.	Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	34396
Attachments:	Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header Bug 34393: (follow-up) QA fixes and further refinement Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header Bug 34393: (follow-up) QA fixes and further refinement

Description Caroline Cyr La Rose 2023-07-25 18:50:33 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the MARC bibliographic frameworks page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add bibliographic? (MARC bibliographic frameworks)
- Change Add framework to New framework
- Change 'Modify framework text' to "Modify framework 'frameworkcode'"
- Change 'Delete framework for 'frameworkname' (frameworkcode)?" to "Confirm deletion of 'frameworkname' (framework code)"
- Add a level for when viewing the MARC structure of a framework "MARC framework for 'frameworkname' (framework code)" (or MARC structure for... ?)
- Change 'Add tag' to 'New tag' (? this one might work since we're adding *to* the framework? If we keep 'Add' we should change the button, so it matches)
- When adding a tag, add a level for the framework
- When viewing/editing subfields, add a level for the framework
- When editing subfields, change 'Edit MARC subfields constraints' to "Modify MARC subfields constraints" (and add the tag number? "Modify MARC subfields constraints for tag 020")

Breadcrumb
- Add bibliographic? (MARC bibliographic frameworks)
- Change Add framework to New framework
- Change 'Delete framework for 'frameworkname' (frameworkcode)?" to "Confirm deletion of 'frameworkname' (framework code)"
- When viewing the MARC structure of a framework, change "Frameworkname (frameworkcode)" to "MARC framework for 'frameworkname' (framework code)" (or MARC structure for... ?)
- Change 'Add tag' to 'New tag' (? this one might work since we're adding *to* the framework? If we keep 'Add' we should change the button, so it matches)
- When viewing subfields, the level for the framework should be "MARC framework for 'frameworkname' (framework code)", so it's consistent if we click on it
- When viewing subfields, correct capitalization (Tag 010 Subfield structure to Tag 010 subfield structure)
- When editing subfields, change 'Edit MARC subfields constraints' to "Modify MARC subfields constraints" (and add the tag number? "Modify MARC subfields constraints for tag 020")

Page header
- Add bibliographic? (MARC bibliographic frameworks)
- Change Add framework to New framework
- Change 'Delete framework for 'frameworkname' (frameworkcode)?" to "Confirm deletion of 'frameworkname' (framework code)"
- When viewing the MARC structure of a framework, change 'Framework' to 'framework' (capitalization) (or change to MARC structure for... ?)
- Change 'Add tag' to 'New tag' (? this one might work since we're adding *to* the framework? If we keep 'Add' we should change the button, so it matches)
- When viewing subfields, remove 'admin' from the page header
- When editing subfields, change 'Tag 020 Subfield constraints' to "Modify MARC subfields constraints for tag 020"

Comment 1 Caroline Cyr La Rose 2023-07-25 19:16:50 UTC

This one was a bit harder since there are so many pages... I might have forgotten something.

Also, in this section, we use "frameworkname (frameworkcode)", as opposed to only the code. Personally I prefer have the name since sometimes the code isn't very telling. Maybe we should do the same for other sections (e.g. "Modify library Centerville (CPL)".

Comment 2 Owen Leonard 2023-10-03 14:45:57 UTC

Created attachment 156506 [details] [review]
Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header

This patch fixes some inconsistencies in the MARC bibliographic
framework administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The file admin/marc_subfields_structure.pl is modified so that it
provides the framework name to the template.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- MARC bibliographic frameworks
  - New framework
  - Edit framework
  - Delete a framework which is not used
  - Delete a framework which is in use
  - Framework MARC structure
    - New tag
    - Edit tag
    - Delete tag
    - View subfields
    - Edit subfields

Comment 3 David Nind 2023-10-03 19:56:35 UTC

Created attachment 156511 [details] [review]
Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header

This patch fixes some inconsistencies in the MARC bibliographic
framework administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The file admin/marc_subfields_structure.pl is modified so that it
provides the framework name to the template.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- MARC bibliographic frameworks
  - New framework
  - Edit framework
  - Delete a framework which is not used
  - Delete a framework which is in use
  - Framework MARC structure
    - New tag
    - Edit tag
    - Delete tag
    - View subfields
    - Edit subfields

Signed-off-by: David Nind <david@davidnind.com>

Comment 4 David Nind 2023-10-03 20:06:18 UTC

I've signed off, but there were two that I wasn't sure of.

1. View subfield constraints
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Tab title: Tag 006 > Books, Booklets, Workbooks (BKS) >  MARC bibliographic frameworks > Administration > Koha

Breadcrumb:  Administration > MARC bibliographic frameworks > Books, Booklets, Workbooks (BKS) > Tag 006 subfield structure

Page title: Tag 006 subfield structure (framework BKS)

Comment: maybe the tab title should be 'Tag XXX subfield structure'?


2. Edit subfield constraints
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Tab title: Edit subfields constraints > Tag 006 > Books, Booklets, Workbooks (BKS) > MARC bibliographic frameworks  > Administration > Koha

Breadcrumb: Administration > MARC bibliographic frameworks > Books, Booklets, Workbooks (BKS) > Tag 006 > Edit subfields constraints

Page title: Tag 006 subfield constraints

Comment: I don't know why, but 'subfields constraints' seems wrong to me. There could be multiple subfields, with each of them having constraints. But it just sounds wrong to me... So I prefer 'Tag 006 subfield constraints'.

Comment 5 Owen Leonard 2023-10-04 11:14:37 UTC

Created attachment 156521 [details] [review]
Bug 34393: (follow-up) QA fixes and further refinement

This patch addresses issues discovered during testing and fixes a couple
of issues which were missed.

Comment 6 Katrin Fischer 2023-10-05 20:51:17 UTC

Created attachment 156585 [details] [review]
Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header

This patch fixes some inconsistencies in the MARC bibliographic
framework administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

The file admin/marc_subfields_structure.pl is modified so that it
provides the framework name to the template.

Test each page to confirm that page title, heading, and breadcrumbs are
consistent:

- MARC bibliographic frameworks
  - New framework
  - Edit framework
  - Delete a framework which is not used
  - Delete a framework which is in use
  - Framework MARC structure
    - New tag
    - Edit tag
    - Delete tag
    - View subfields
    - Edit subfields

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 7 Katrin Fischer 2023-10-05 20:51:20 UTC

Created attachment 156586 [details] [review]
Bug 34393: (follow-up) QA fixes and further refinement

This patch addresses issues discovered during testing and fixes a couple
of issues which were missed.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 8 Tomás Cohen Arazi (tcohen) 2023-10-09 14:43:04 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 9 Fridolin Somers 2023-10-09 19:17:47 UTC

Not pushed to 23.05.x