Bug 34401

Summary:	Inconsistencies in Item search fields page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	barbara.johnson, fridolin.somers
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	34396
Attachments:	Bug 34401: Fix inconsistencies in Item search fields page titles, breadcrumbs, and headers Bug 34401: Fix inconsistencies in Item search fields page titles, breadcrumbs, and headers Bug 34401: Fix inconsistencies in Item search fields page titles, breadcrumbs, and headers

Description Caroline Cyr La Rose 2023-07-25 20:00:43 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Item search fields page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add a level for when adding a new search field 'New item search field'
- Add a level for when modifying an existing search field "Modify item search field 'code'"


Breadcrumb
- Add a level for when adding a new search field 'New item search field'
- Add single quotes around the search field code when modifying a search field

Page header
- Change 'Add a new field' to 'New item search field'
- The styling of the header for the New X page is different from the usual
- Change 'Item search field: test' to "Modify item search field 'code'"
- Second level header necessary?

No special page for deletion confirmation, it is simply a browser prompt.

Comment 1 Owen Leonard 2023-10-05 18:18:39 UTC

Created attachment 156580 [details] [review]
Bug 34401: Fix inconsistencies in Item search fields page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the item search fields
administration page, making sure the page title, breadcrumb navigation,
and page headers are consistent with each other.

The patch makes some changes to the way new item search fields are added
in order to keep the display consistent with other similar interfaces:
The "add" form is no longer shown dynamically from the page listing item
search fields. Clicking the "New search field" toolbar button will now
take you to the same template used for editing existing search fields.
This allows us to put the correct context into page title, breadcrumbs,
and headings.

To test, apply the patch and go to Administration -> Item search fields.
Test the process of adding a new search field and editing an existing
search field.

Comment 2 ByWater Sandboxes 2023-10-12 18:23:26 UTC

Created attachment 156990 [details] [review]
Bug 34401: Fix inconsistencies in Item search fields page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the item search fields
administration page, making sure the page title, breadcrumb navigation,
and page headers are consistent with each other.

The patch makes some changes to the way new item search fields are added
in order to keep the display consistent with other similar interfaces:
The "add" form is no longer shown dynamically from the page listing item
search fields. Clicking the "New search field" toolbar button will now
take you to the same template used for editing existing search fields.
This allows us to put the correct context into page title, breadcrumbs,
and headings.

To test, apply the patch and go to Administration -> Item search fields.
Test the process of adding a new search field and editing an existing
search field.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

Comment 3 Katrin Fischer 2023-10-14 15:28:38 UTC

Created attachment 157151 [details] [review]
Bug 34401: Fix inconsistencies in Item search fields page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the item search fields
administration page, making sure the page title, breadcrumb navigation,
and page headers are consistent with each other.

The patch makes some changes to the way new item search fields are added
in order to keep the display consistent with other similar interfaces:
The "add" form is no longer shown dynamically from the page listing item
search fields. Clicking the "New search field" toolbar button will now
take you to the same template used for editing existing search fields.
This allows us to put the correct context into page title, breadcrumbs,
and headings.

To test, apply the patch and go to Administration -> Item search fields.
Test the process of adding a new search field and editing an existing
search field.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-10-17 17:48:03 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-10-25 06:26:27 UTC

Not pushed to 23.05.x