Bug 34406

Summary:	Inconsistencies in Identity providers/domains page titles, breadcrumbs, and header
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	34396
Attachments:	Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers Bug 34406: (QA follow-up) Add another "Identity provier" to "domains"

Description Caroline Cyr La Rose 2023-07-25 21:13:33 UTC

While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Identity providers page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Change 'Edit identity provider' to "Modify identity provider 'code'" or "Modify identity provider 'description' (code)"
- Add a level for "Email domains for 'code'" or "Email domains for 'description' (code)"
- Change 'Edit identity provider domain' to "Modify email domain 'domain'" 

Breadcrumb
- Change 'Edit identity provider' to "Modify identity provider 'code'" or "Modify identity provider 'description' (code)"
- In Domains, put code in single quotes (or descriptions in single quotes and code in parentheses)
- Change Domains to Email domains
- Change 'Edit domain' to "Modify email domain 'domain'"

Page header
- Change 'Edit identity provider' to "Modify identity provider 'code'" or "Modify identity provider 'description' (code)"
- Change 'Identity provider email domains' to "Email domains for 'code'" or "Email domains for 'description' (code)"
- Change 'New email domain' to "New email domain for 'code'" or "New email domain for 'description' (code)"
- Change 'Edit identity provider domain' to "Modify email domain 'domain'" 

There is no special page when deleting an email domain, only a modal.

There is no special page when deleting an identity provider, only a modal.

Comment 1 Owen Leonard 2023-10-06 14:15:04 UTC

Created attachment 156622 [details] [review]
Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the templates for identity
providers and identity provider domains, making sure the page title,
breadcrumb navigation, and page headers are consistent with each other.

To test, apply the patch and check these views:

- Administration -> Identity providers
  - New identity provider
  - Edit identity provider
  - Confirm deletion of identity provider
  - Manage domains
    - New domain
    - Edit domain
    - Confirm deletion of domain

Comment 2 David Nind 2023-10-29 00:09:19 UTC

Created attachment 158021 [details] [review]
Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the templates for identity
providers and identity provider domains, making sure the page title,
breadcrumb navigation, and page headers are consistent with each other.

To test, apply the patch and check these views:

- Administration -> Identity providers
  - New identity provider
  - Edit identity provider
  - Confirm deletion of identity provider
  - Manage domains
    - New domain
    - Edit domain
    - Confirm deletion of domain

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2023-11-01 22:20:21 UTC

Looking at how the rest of the patch changes things, should this not read "Identify provider domains for ..."?

+                <span>[% tx("Domains for '{identity_provider_code}'", {identity_provider_code = identity_provider_code}) | html %]</span>

Comment 4 Katrin Fischer 2023-11-01 22:22:03 UTC

Created attachment 158221 [details] [review]
Bug 34406: Fix inconsistencies in Identity providers/domains page titles, breadcrumbs, and headers

This patch fixes some inconsistencies in the templates for identity
providers and identity provider domains, making sure the page title,
breadcrumb navigation, and page headers are consistent with each other.

To test, apply the patch and check these views:

- Administration -> Identity providers
  - New identity provider
  - Edit identity provider
  - Confirm deletion of identity provider
  - Manage domains
    - New domain
    - Edit domain
    - Confirm deletion of domain

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Katrin Fischer 2023-11-01 22:22:05 UTC

Created attachment 158222 [details] [review]
Bug 34406: (QA follow-up) Add another "Identity provier" to "domains"

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 6 Tomás Cohen Arazi (tcohen) 2023-11-03 15:05:59 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 7 Fridolin Somers 2023-11-10 02:11:58 UTC

I prefer not to backport to avoid translation work