|
Description
Lucas Gass (lukeg)
2023-07-27 19:12:59 UTC
Created attachment 154001 [details] [review] Bug 34438: Add lang field to OPAC patron self registration form Created attachment 154002 [details] [review] Bug 34438: Add lang to borrower_modification table To test: 1. Install a language pack ( sudo koha-translate -i es-ES ) 2. Turn on the system preference TranslateNotices 3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form. 4. Apply patch, updatedatabase, restart_all 5. Go to the OPAC self reg form and notice the Preferred language for notices: 6. Use the PatronSelfRegistrationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField to make sure you can make the field requied/hidden. 7. Login to the OPAC and go to patron details, make sure you can modify the Preferred language for notices field successfully. *** Bug 28362 has been marked as a duplicate of this bug. *** Created attachment 155775 [details] [review] Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> Created attachment 155776 [details] [review] Bug 34438: Add lang to borrower_modification table To test: 1. Install a language pack ( sudo koha-translate -i es-ES ) 2. Turn on the system preference TranslateNotices 3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form. 4. Apply patch, updatedatabase, restart_all 5. Go to the OPAC self reg form and notice the Preferred language for notices: 6. Use the PatronSelfRegistrationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField to make sure you can make the field requied/hidden. 7. Login to the OPAC and go to patron details, make sure you can modify the Preferred language for notices field successfully. Signed-off-by: David Nind <david@davidnind.com> Hi Lucas. I've signed off, but I did notice this with the OPAC for 7: - You can easily change the preferred language for notices under OPAC account > Messaging. - However, if you attempt to change it under OPAC account > Personal details, you get a message "Thank you. Your updates have been submitted. A librarian will review your updates before applying them." and it appears in the staff interface under Patrons requesting modifications. I'm not sure whether this is expected, or needs updating. David Maybe it's not good to have it in 2 spots by default. Should we include an update to hide it for existing installations? Hi Lucas, * Rebase was easy, so I did it myself, but: * The Schema change should be a separate DO NOT PUSH style patch. * Change in kohastructure.sql is missing I like this - please fix! (In reply to Katrin Fischer from comment #8) > Hi Lucas, > > * Rebase was easy, so I did it myself, but: > * The Schema change should be a separate DO NOT PUSH style patch. > * Change in kohastructure.sql is missing > > I like this - please fix! ... and please perltidy! Created attachment 158152 [details] [review] Bug 34438: Schema changes [DO NOT PUSH] Created attachment 158153 [details] [review] Bug 34438: Database update Created attachment 158154 [details] [review] Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> Created attachment 158155 [details] [review] Bug 34438: ( follow-up ): Amend kohastructure.sql Fixed and back to NSO. Created attachment 158156 [details] [review] Bug 34438: Schema changes [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Created attachment 158157 [details] [review] Bug 34438: Database update Signed-off-by: David Nind <david@davidnind.com> Created attachment 158158 [details] [review] Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> Created attachment 158159 [details] [review] Bug 34438: ( follow-up ): Amend kohastructure.sql Signed-off-by: David Nind <david@davidnind.com> Please fix: WARN Koha/Schema/Result/BorrowerModification.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 176, now: 178) WARN installer/data/mysql/atomicupdate/bug_34438.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 2) OK installer/data/mysql/kohastructure.sql OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt FAIL opac/opac-memberentry.pl FAIL valid "my" variable $defaultCategory masks earlier declaration in same scope Processing additional checks * Commit title does not contain 'follow-up' correctly spelt - 61e1edc84b I believe this line should have been deleted in the rebase:
+my $defaultCategory = Koha::Patron::Categories->find(C4::Context->preference('PatronSelfRegistrationDefaultCategory'));
Created attachment 158181 [details] [review] Bug 34438: Schema changes [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Created attachment 158182 [details] [review] Bug 34438: Database update Signed-off-by: David Nind <david@davidnind.com> Created attachment 158183 [details] [review] Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> Created attachment 158184 [details] [review] Bug 34438: (follow-up): Amend kohastructure.sql Signed-off-by: David Nind <david@davidnind.com> Created attachment 158196 [details] [review] Bug 34438: Schema changes [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158197 [details] [review] Bug 34438: Database update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158198 [details] [review] Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158199 [details] [review] Bug 34438: (follow-up): Amend kohastructure.sql Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |