To recreate: 1. Install a language pack ( sudo koha-translate -i es-ES ) 2. Turn on the system preference TranslateNotices 3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form.
Created attachment 154001 [details] [review] Bug 34438: Add lang field to OPAC patron self registration form
Created attachment 154002 [details] [review] Bug 34438: Add lang to borrower_modification table To test: 1. Install a language pack ( sudo koha-translate -i es-ES ) 2. Turn on the system preference TranslateNotices 3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form. 4. Apply patch, updatedatabase, restart_all 5. Go to the OPAC self reg form and notice the Preferred language for notices: 6. Use the PatronSelfRegistrationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField to make sure you can make the field requied/hidden. 7. Login to the OPAC and go to patron details, make sure you can modify the Preferred language for notices field successfully.
*** Bug 28362 has been marked as a duplicate of this bug. ***
Created attachment 155775 [details] [review] Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com>
Created attachment 155776 [details] [review] Bug 34438: Add lang to borrower_modification table To test: 1. Install a language pack ( sudo koha-translate -i es-ES ) 2. Turn on the system preference TranslateNotices 3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form. 4. Apply patch, updatedatabase, restart_all 5. Go to the OPAC self reg form and notice the Preferred language for notices: 6. Use the PatronSelfRegistrationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField to make sure you can make the field requied/hidden. 7. Login to the OPAC and go to patron details, make sure you can modify the Preferred language for notices field successfully. Signed-off-by: David Nind <david@davidnind.com>
Hi Lucas. I've signed off, but I did notice this with the OPAC for 7: - You can easily change the preferred language for notices under OPAC account > Messaging. - However, if you attempt to change it under OPAC account > Personal details, you get a message "Thank you. Your updates have been submitted. A librarian will review your updates before applying them." and it appears in the staff interface under Patrons requesting modifications. I'm not sure whether this is expected, or needs updating. David
Maybe it's not good to have it in 2 spots by default. Should we include an update to hide it for existing installations?