Bug 34438 - OPAC self registration form does not include lang ( Preferred language for notices ) field
Summary: OPAC self registration form does not include lang ( Preferred language for no...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
: 28362 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-07-27 19:12 UTC by Lucas Gass
Modified: 2023-09-18 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 34438: Add lang field to OPAC patron self registration form (7.96 KB, patch)
2023-07-27 20:48 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34438: Add lang to borrower_modification table (2.41 KB, patch)
2023-07-27 20:48 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34438: Add lang field to OPAC patron self registration form (8.01 KB, patch)
2023-09-18 00:29 UTC, David Nind
Details | Diff | Splinter Review
Bug 34438: Add lang to borrower_modification table (2.45 KB, patch)
2023-09-18 00:29 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-07-27 19:12:59 UTC
To recreate:

1. Install a language pack ( sudo koha-translate -i es-ES )
2. Turn on the system preference TranslateNotices
3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form.
Comment 1 Lucas Gass 2023-07-27 20:48:02 UTC
Created attachment 154001 [details] [review]
Bug 34438: Add lang field to OPAC patron self registration form
Comment 2 Lucas Gass 2023-07-27 20:48:04 UTC
Created attachment 154002 [details] [review]
Bug 34438: Add lang to borrower_modification table

To test:
1. Install a language pack ( sudo koha-translate -i es-ES )
2. Turn on the system preference TranslateNotices
3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form.
4. Apply patch, updatedatabase, restart_all
5. Go to the OPAC self reg form and notice the Preferred language for notices:
6. Use the  PatronSelfRegistrationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField to make sure you can make the field requied/hidden.
7. Login to the OPAC and go to patron details, make sure you can modify the Preferred language for notices field successfully.
Comment 3 Katrin Fischer 2023-07-28 08:48:33 UTC
*** Bug 28362 has been marked as a duplicate of this bug. ***
Comment 4 David Nind 2023-09-18 00:29:21 UTC
Created attachment 155775 [details] [review]
Bug 34438: Add lang field to OPAC patron self registration form

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-09-18 00:29:23 UTC
Created attachment 155776 [details] [review]
Bug 34438: Add lang to borrower_modification table

To test:
1. Install a language pack ( sudo koha-translate -i es-ES )
2. Turn on the system preference TranslateNotices
3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form.
4. Apply patch, updatedatabase, restart_all
5. Go to the OPAC self reg form and notice the Preferred language for notices:
6. Use the  PatronSelfRegistrationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField to make sure you can make the field requied/hidden.
7. Login to the OPAC and go to patron details, make sure you can modify the Preferred language for notices field successfully.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-09-18 00:33:49 UTC
Hi Lucas.

I've signed off, but I did notice this with the OPAC for 7:

- You can easily change the preferred language for notices under OPAC account > Messaging.

- However, if you attempt to change it under OPAC account > Personal details, you get a message "Thank you. Your updates have been submitted. A librarian will review your updates before applying them." and it appears in the staff interface under Patrons requesting modifications.

I'm not sure whether this is expected, or needs updating.

David
Comment 7 Katrin Fischer 2023-09-18 19:57:24 UTC
Maybe it's not good to have it in 2 spots by default. Should we include an update to hide it for existing installations?