Bug 34443

Summary:	Spelling: Patron search pop-up Sort1: should be Sort 1:
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	minor
Priority:	P5 - low	CC:	fridolin.somers, m.de.rooy
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.05,22.11.11
Circulation function:
Attachments:	Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1 Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1 Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1

Description Katrin Fischer 2023-07-29 21:40:45 UTC

The patron search pop-up (linking guarantors, adding roles to agreements) has 2 new search fields:

* Sort1:
* Sort2:

Both should be relabelled to match with the normal patron form:

* Sort 1:
* Sort 2:

It might also be nice to move them into a second column next to the other search options as currenlty they take up a lot of space in the small pop-up window.

Comment 1 Owen Leonard 2023-09-08 15:47:20 UTC

Created attachment 155444 [details] [review]
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1

This patch instances of "Sort1" and "Sort2" being used
as labels in the interface, replacing the strings with "Sort 1" and
"Sort 2"

To test, apply the patch and test this page:

With the borrowerRelationship system preference populated, edit a
child record and click the "Add guarantor" button. There are two
fields in the form with the updated labels.

Comment 2 Laura Escamilla 2023-09-08 17:15:19 UTC

Created attachment 155451 [details] [review]
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1

This patch instances of "Sort1" and "Sort2" being used
as labels in the interface, replacing the strings with "Sort 1" and
"Sort 2"

To test, apply the patch and test this page:

With the borrowerRelationship system preference populated, edit a
child record and click the "Add guarantor" button. There are two
fields in the form with the updated labels.

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Comment 3 Marcel de Rooy 2023-09-15 06:07:52 UTC

Created attachment 155633 [details] [review]
Bug 34443: Spelling: Patron search pop-up Sort1: should be Sort 1

This patch instances of "Sort1" and "Sort2" being used
as labels in the interface, replacing the strings with "Sort 1" and
"Sort 2"

To test, apply the patch and test this page:

With the borrowerRelationship system preference populated, edit a
child record and click the "Add guarantor" button. There are two
fields in the form with the updated labels.

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-09-15 14:58:46 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-10-05 18:06:56 UTC

Pushed to 23.05.x for 23.05.05

Comment 6 Jacob O'Mara 2023-10-17 13:37:36 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x