|
Description
Pedro Amorim
2023-08-03 10:10:52 UTC
Created attachment 154216 [details] [review] Bug 34468: Add progress callback to job_progress.js Created attachment 154217 [details] [review] Bug 34468: Update how we call updateProgress in stage-marc-import.tt Calling anyone who can SO/QA this by testing the stage marc import tool and progress bar. This is something we're using/need for ERM Usage Statistics. If you could add a test plan, I'll happily have a go at testing. For example, what it does, and what to expect before and after the patches are applied. (In reply to David Nind from comment #5) > If you could add a test plan, I'll happily have a go at testing. > > For example, what it does, and what to expect before and after the patches > are applied. Hi David, thank you! These patches change the current updateProgress function to accept a progress callback (a function that is called every time the bar progresses) in addition to the already existing callback that is called when the progress bar finishes. It's not expected to change any current behavior in master because updateProgress is only used once in the stage marc import tool using the already existing callback, and these patches aim to keep that. I think the most appropriate test plan here is to make sure it doesn't break existing functionality, by using the test plan in bug 31666 : Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Does this patch affect the progress bar when uploading the MARC file or the progress bar shown when staging the file for import? (In reply to Owen Leonard from comment #7) > Does this patch affect the progress bar when uploading the MARC file or the > progress bar shown when staging the file for import? It should not change any current behavior, no. This is only a preparation bug for bug 34587 that changes updateProgress to accept an array of callbacks, instead of just a callback. Created attachment 154739 [details] [review] Bug 34468: Add progress callback to job_progress.js These patches change the current updateProgress function to accept a progress callback (a function that is called every time the bar progresses) in addition to the already existing callback that is called when the progress bar finishes. It's not expected to change any current behavior in master because updateProgress is only used once in the stage marc import tool using the already existing callback, and these patches aim to keep that. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 154740 [details] [review] Bug 34468: Update how we call updateProgress in stage-marc-import.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 157517 [details] [review] Bug 34468: Add progress callback to job_progress.js These patches change the current updateProgress function to accept a progress callback (a function that is called every time the bar progresses) in addition to the already existing callback that is called when the progress bar finishes. It's not expected to change any current behavior in master because updateProgress is only used once in the stage marc import tool using the already existing callback, and these patches aim to keep that. Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 157518 [details] [review] Bug 34468: Update how we call updateProgress in stage-marc-import.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All working as described and a positive change. No regressions found, QA scripts happy. Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |