| Summary: | Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Command-line Utilities | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | m.de.rooy, robin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.10
|
|
| Circulation function: | |||
| Bug Depends on: | 26311 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons
Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons |
||
|
Description
Fridolin Somers
2023-08-09 07:36:26 UTC
Created attachment 154328 [details] [review] Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl But this is not relevant for expired patrons, especially in child categories. Check should skip expired patrons 1) Set a non-expired patron with invalid age 2) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see the patron 3) Edit patron to be expired 4) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you do not see the patron Created attachment 154330 [details] [review] Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl But this is not relevant for expired patrons, especially in child categories. Check should skip expired patrons 1) Set a non-expired patron with invalid age 2) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see the patron 3) Edit patron to be expired 4) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you do not see the patron Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 154790 [details] [review] Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl But this is not relevant for expired patrons, especially in child categories. Check should skip expired patrons 1) Set a non-expired patron with invalid age 2) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see the patron 3) Edit patron to be expired 4) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you do not see the patron Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] If we do not want to test valid age for expired patrons, you should obviously test expired first. Reversing the order in the test. Putting it in the search criteria would be nicer but leads to more complicated code. Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |