Bug 34505 - Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons
Summary: Patron invalid age in search_for_data_inconsistencies.pl should skip expired ...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 26311
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-09 07:36 UTC by Fridolin Somers
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons (1.51 KB, patch)
2023-08-09 07:47 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons (1.58 KB, patch)
2023-08-09 13:35 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons (1.90 KB, patch)
2023-08-25 09:37 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-08-09 07:36:26 UTC
Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl
But this is not relevant for expired patrons, especially in child categories.
Check should skip expired patrons
Comment 1 Fridolin Somers 2023-08-09 07:47:00 UTC
Created attachment 154328 [details] [review]
Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons

Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl
But this is not relevant for expired patrons, especially in child categories.
Check should skip expired patrons

1) Set a non-expired patron with invalid age
2) Run misc/maintenance/search_for_data_inconsistencies.pl
=> Check you see the patron
3) Edit patron to be expired
4) Run misc/maintenance/search_for_data_inconsistencies.pl
=> Check you do not see the patron
Comment 2 Caroline Cyr La Rose 2023-08-09 13:35:46 UTC
Created attachment 154330 [details] [review]
Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons

Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl
But this is not relevant for expired patrons, especially in child categories.
Check should skip expired patrons

1) Set a non-expired patron with invalid age
2) Run misc/maintenance/search_for_data_inconsistencies.pl
=> Check you see the patron
3) Edit patron to be expired
4) Run misc/maintenance/search_for_data_inconsistencies.pl
=> Check you do not see the patron

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Marcel de Rooy 2023-08-25 09:37:52 UTC
Created attachment 154790 [details] [review]
Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons

Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl
But this is not relevant for expired patrons, especially in child categories.
Check should skip expired patrons

1) Set a non-expired patron with invalid age
2) Run misc/maintenance/search_for_data_inconsistencies.pl
=> Check you see the patron
3) Edit patron to be expired
4) Run misc/maintenance/search_for_data_inconsistencies.pl
=> Check you do not see the patron

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] If we do not want to test valid age for expired patrons, you should
obviously test expired first. Reversing the order in the test.
Putting it in the search criteria would be nicer but leads to more
complicated code.
Comment 4 Tomás Cohen Arazi 2023-08-29 17:58:43 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-30 07:17:41 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-08-31 10:24:31 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x