Summary: | Patron search results: Add a CSS class to patron email to ease customization | ||
---|---|---|---|
Product: | Koha | Reporter: | Sally <sally.healey> |
Component: | Patrons | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | RESOLVED FIXED | QA Contact: | Victor Grousset/tuxayo <victor> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kebliss, kyle.m.hall, lucas, martin.renvoize, oleonard, pedro.amorim, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34574 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.05.00,23.11.06
|
Circulation function: | |
Bug Depends on: | 35629 | ||
Bug Blocks: | |||
Attachments: |
Demo patron long e-mail
Bug 34575: Add a CSS class to patron email Bug 34575: Add a CSS class to patron email Bug 34575: Add a CSS class to patron email |
Description
Sally
2023-08-18 13:09:48 UTC
Created attachment 160207 [details] Demo patron long e-mail Hi Sally, I've added an attachment with a patron in the table with an e-mail address of 50 characters. At a glance, the table looks okay. Please note that in this screenshot I have bug 34574 applied, i.e. the issue with the library and patron categories column does not happen here. Are you able to confirm if this still requires looking into? Or are you able to provide a new/different example? Thank you! (In reply to Pedro Amorim from comment #1) > Created attachment 160207 [details] > Demo patron long e-mail > > Hi Sally, I've added an attachment with a patron in the table with an e-mail > address of 50 characters. > > At a glance, the table looks okay. Please note that in this screenshot I > have bug 34574 applied, i.e. the issue with the library and patron > categories column does not happen here. > > Are you able to confirm if this still requires looking into? Or are you able > to provide a new/different example? > > Thank you! Hi Pedro, It's still an issue for us. As a simple solution, could we just add a class to email? For Henry in the test data, this is what's in the table: <div class="address"> <ul> <li class="patronaddress1"> 4345 Library Rd. </li> <li class="patroncity">Springfield, MA 44224</li> <li>Email: <a href="mailto:example@test.com">example@test.com</a> </li> </ul> </div> Note that address1 and city both have classes, but email doesn't. If a class was added to email, as it is for the other address lines: <div class="address"> <ul> <li class="patronaddress1"> 4345 Library Rd. </li> <li class="patroncity">Springfield, MA 44224</li> <li class="patronemail">Email: <a href="mailto:example@test.com">example@test.com</a> </li> </ul> </div> Then I can just hide it with CSS - and nobody else is affected by the change? What do you think? Created attachment 160229 [details] [review] Bug 34575: Add a CSS class to patron email Adds a CSS class to the patron email section in the 'name-address' column of search results in members-home.pl No functional behaviour change. (In reply to Sally from comment #2) > Hi Pedro, > > It's still an issue for us. > > As a simple solution, could we just add a class to email? I love this suggestion, submitted the patch, new HTML should now be: <ul> <li class="patronaddress1">31 4345 Library Rd. </li> <li class="patroncity">City in address zip postal, test</li> <li class="patronemail">Email: <a href="mailto:randomlongemailstringtobeusedasanexample%40koha.com">randomlongemailstringtobeusedasanexample@koha.com</a></li> </ul> Thank you. Created attachment 160264 [details] [review] Bug 34575: Add a CSS class to patron email Adds a CSS class to the patron email section in the 'name-address' column of search results in members-home.pl No functional behaviour change. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Brilliant, thanks so much, Pedro - exactly what I needed! :) Tried to rename the ticket, feel free to improve if I misunderstood. We have classes like patron_name and patroncity. If the style is already inconsistent, let's go for the more readable one for new classes. So patron_email. Patch amended. Feel free to comment if that doesn't look like a good change. Created attachment 162854 [details] [review] Bug 34575: Add a CSS class to patron email Adds a CSS class to the patron email section in the 'name-address' column of search results in members-home.pl No functional behaviour change. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Small useful enhancement, Pushed to 23.11.x for 23.11.06 Enhancement will not be backported to 23.05.x |