Do a find for [% CASE 'name-address' %] you'll notice there are 2 identical entries with the difference being me.othernames in "data".
The patch that seems to have added this is: https://github.com/Koha-Community/Koha/commit/a853b06
(In reply to Pedro Amorim from comment #0) > Do a find for [% CASE 'name-address' %] you'll notice there are 2 identical > entries with the difference being me.othernames in "data". Meant middle_name here, not othernames.
Created attachment 160209 [details] [review] Bug 35629: Remove redundant code
No functional behavior here as I believe it was already defaulting to the 'correct' first [% CASE 'name-address' %] but to test would be make sure patron search is working as before, all considered names are shown before and after applying patch, including middle_name.
Created attachment 160300 [details] [review] Bug 35629: Remove redundant code Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 160351 [details] [review] Bug 35629: Remove redundant code Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
To me, this is clearly a merge error in the first place. All working well, no regressions and QA scripts are happy. Passing QA
Definitely a bad rebase conflict resolution. Thanks, Pedro!
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Backported to 23.05.x for upcoming 23.05.08