Bug 34616

Summary: "Edit SMTP server" page - Default SMTP configuration dialog has some issues
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: Staff interfaceAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart, martin.renvoize, matt.blenkinsop, nick, oleonard, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34622
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34205
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04
Circulation function:
Bug Depends on: 27424    
Bug Blocks: 34408    
Attachments: issue
Bug 34616: Add native bootstrap behaviour to default server dialog
Bug 34616: Fix showing default server info on edit SMTP server page
Bug 34616: Move default server info outside the <fieldset>
Bug 34616: Add native bootstrap behaviour to default server dialog
Bug 34616: Fix showing default server info on edit SMTP server page
Bug 34616: Move default server info outside the <fieldset>
Bug 34616: Add native bootstrap behaviour to default server dialog
Bug 34616: Fix showing default server info on edit SMTP server page
Bug 34616: Move default server info outside the <fieldset>

Description Pedro Amorim 2023-08-25 14:13:38 UTC
Created attachment 154814 [details]
issue

To reproduce, on k-t-d:
- Add a new SMTP server
- Visit the edit page for that SMTP server
Comment 1 Pedro Amorim 2023-08-25 14:19:49 UTC
Hmm... can't reproduce. Must've been some changing of branches hic-up!
Comment 2 Owen Leonard 2023-08-25 15:26:01 UTC
I can reproduce the problem. The template shows a "default configuration" dialog inside the SMTP server entry form. I don't know why.

Was the intention for this dialog to show above the form? Or should it not display at all?
Comment 3 Pedro Amorim 2023-08-25 15:34:41 UTC
(In reply to Owen Leonard from comment #2)
> I can reproduce the problem. The template shows a "default configuration"
> dialog inside the SMTP server entry form. I don't know why.
> 
> Was the intention for this dialog to show above the form? Or should it not
> display at all?

It's so weird, cause I can't reproduce it intentionally every time.
It sometimes happens and other times it doesn't, at least for me!

The intention, I believe, is not display at all in that edit form. That dialog should only display in the SMTP servers list page afaik.
Comment 4 Pedro Amorim 2023-08-25 16:31:20 UTC Comment hidden (obsolete)
Comment 5 Pedro Amorim 2023-08-25 16:32:38 UTC
(In reply to Owen Leonard from comment #2)
> I can reproduce the problem. The template shows a "default configuration"
> dialog inside the SMTP server entry form. I don't know why.
> 
> Was the intention for this dialog to show above the form? Or should it not
> display at all?


Wait, I stand corrected. It seems this is intended to show on servers that are not tagged as the "is_default" SMTP Server. But the styling seems to have gone crazy.
Comment 6 Pedro Amorim 2023-08-25 16:46:24 UTC Comment hidden (obsolete)
Comment 7 Pedro Amorim 2023-08-25 16:46:27 UTC Comment hidden (obsolete)
Comment 8 Pedro Amorim 2023-08-25 16:46:30 UTC Comment hidden (obsolete)
Comment 9 Owen Leonard 2023-08-25 18:31:46 UTC
Created attachment 154844 [details] [review]
Bug 34616: Add native bootstrap behaviour to default server dialog

Test plan:
Create a new SMTP server
Tick the 'default server' checkbox
Verify it now has a backdrop, closes if u click the backdrop or press 'esc'
The Yes and No buttons are now styled properly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 10 Owen Leonard 2023-08-25 18:31:48 UTC
Created attachment 154845 [details] [review]
Bug 34616: Fix showing default server info on edit SMTP server page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 11 Owen Leonard 2023-08-25 18:31:51 UTC
Created attachment 154846 [details] [review]
Bug 34616: Move default server info outside the <fieldset>

Also DRY current default information dialog block

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Jonathan Druart 2023-08-30 13:55:49 UTC
Created attachment 154960 [details] [review]
Bug 34616: Add native bootstrap behaviour to default server dialog

Test plan:
Create a new SMTP server
Tick the 'default server' checkbox
Verify it now has a backdrop, closes if u click the backdrop or press 'esc'
The Yes and No buttons are now styled properly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Jonathan Druart 2023-08-30 13:55:52 UTC
Created attachment 154961 [details] [review]
Bug 34616: Fix showing default server info on edit SMTP server page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Jonathan Druart 2023-08-30 13:55:55 UTC
Created attachment 154962 [details] [review]
Bug 34616: Move default server info outside the <fieldset>

Also DRY current default information dialog block

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 15 Tomás Cohen Arazi (tcohen) 2023-09-01 14:10:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 16 Fridolin Somers 2023-09-08 00:30:08 UTC
Pushed to 23.05.x for 23.05.04
Comment 17 Matt Blenkinsop 2023-09-08 09:42:35 UTC
Not backporting to 22.11.x - missing dependency 27424

Nice work everyone!