Summary: | Update jQuery-validate plugin to 1.20.0 | ||
---|---|---|---|
Product: | Koha | Reporter: | Evelyn Hartline <evelyn> |
Component: | Architecture, internals, and plumbing | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, dcook, didier.gautheron, fridolin.somers, jonathan.druart, laurent.ducos, lucas, m.de.rooy, nick, oleonard, phil, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.05.00,23.11.03,23.05.09,22.11.15
|
Circulation function: | |
Bug Depends on: | 35584, 30859 | ||
Bug Blocks: | |||
Attachments: |
Bug 34623: Update jQuery-validate plugin to 1.20.0
Bug 34623: Update jQuery-validate plugin to 1.20.0 Bug 34623: Update jQuery-validate plugin to 1.20.0 |
Description
Evelyn Hartline
2023-08-25 17:26:22 UTC
*** Bug 34914 has been marked as a duplicate of this bug. *** CVE: https://nvd.nist.gov/vuln/detail/CVE-2021-43306 is also an issue here. Created attachment 160133 [details] [review] Bug 34623: Update jQuery-validate plugin to 1.20.0 This patch updates the jQuery validation plugin in both the staff interface and the OPAC to the latest version, 1.20.0. To test, apply the patch and clear your browser cache if necessary. Test various pages in the staff client to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Perform the same check of the "Change password" form in the OPAC. Created attachment 161498 [details] [review] Bug 34623: Update jQuery-validate plugin to 1.20.0 This patch updates the jQuery validation plugin in both the staff interface and the OPAC to the latest version, 1.20.0. To test, apply the patch and clear your browser cache if necessary. Test various pages in the staff client to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Perform the same check of the "Change password" form in the OPAC. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks Owen, my apologies that it took me a while to get back to this. > - Description, start date, and end date are required Dates are not required with or without the patch. It's possible to submit the form without a date and it will silently fail server side. Not due to this patch so no problem for this ticket. > - Start date must be before end date Something else (flatpickr likely) is already enforcing this first so can't really test it. --- Additional testing: acquisition => new contact - Name - end date after start date: Something else (flatpickr likely) is already enforcing this first. installer, onboarding - patron category - Enrollment period: months - Category code (when submitting the form) - Description (when submitting the form) - Create Koha administrator patron - many fields - password OPAC: - personal details: change Primary email, Secondary email, Alternate address: email additional content - new news tools - patron image upload --- note: to find (hopefully all) usage of the validator search the code with something equivalent to rg "\.validate\(" -A 20 Displaying the 20 line following a match allow to see the rules that are validate and search some unusual ones. Created attachment 162086 [details] [review] Bug 34623: Update jQuery-validate plugin to 1.20.0 This patch updates the jQuery validation plugin in both the staff interface and the OPAC to the latest version, 1.20.0. To test, apply the patch and clear your browser cache if necessary. Test various pages in the staff client to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Perform the same check of the "Change password" form in the OPAC. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed to master 24.05.00 |