Thanks David Nind for noticing it in Bug 34900 > I've just had a quick look (not comprehensive), and it looks like there are > some software licences missing, including: > - DataTables (koha-tmpl/intranet-tmpl/lib/datatables) > - GreyBox (koha-tmpl/intranet-tmpl/lib/greybox) > - Some jQuery plugins - jsTree, rowGroup (doesn't look the same as > jquery.dataTables.grouping.js), fnReloadAjax (part of DataTables?), > Humanized Messages, jquery.dataTables.columnFilter.js (part of DataTables?), > highlight (part of DataTables?), jquery-jeditable > (koha-tmpl/intranet-tmpl/lib/jquery/plugins/) > - linters (several) (koha-tmpl/intranet-tmpl/lib/linters) > - sortable (koha-tmpl/intranet-tmpl/lib/linters/sortable) > - vis-timeline and vis-graph2d (koha-tmpl/intranet-tmpl/lib/vis-timeline/) > - media.match.js (koha-tmpl/opac-tmpl/lib/)
Created attachment 160116 [details] [review] Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct.
Created attachment 160162 [details] [review] Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 160163 [details] [review] Bug 35584: (follow-up) Add license information and fix sort order Add license information and links. Put in alphabetical order. Signed-off-by: David Nind <david@davidnind.com>
Thanks Owen!
Created attachment 160231 [details] [review] Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 160232 [details] [review] Bug 35584: (follow-up) Add license information and fix sort order Add license information and links. Put in alphabetical order. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 160233 [details] [review] Bug 35584: (QA Follow-up): Typo fix: GreBox -> Greybox Capitalization fix: JavaScript case Order to match header fix: jsTree jQuery -> jQuery jsTree Capitalization fix: treetable -> Treetable capitalization Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
The dependency here is still "NSO" and the last patch here should have a proper description please :)
Created attachment 160526 [details] [review] Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 160527 [details] [review] Bug 35584: (follow-up) Add license information and fix sort order Add license information and links. Put in alphabetical order. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 160528 [details] [review] Bug 35584: (QA follow-up): Typo fix: GreBox -> Greybox Capitalization fix: JavaScript case Order to match header fix: jsTree jQuery -> jQuery jsTree Capitalization fix: treetable -> Treetable capitalization Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
It looks like a double up: jQuery UI Virtual Keyboard Virtual Keyboard Same version and link?
Created attachment 160653 [details] [review] Bug 35584: (follow-up) Remove duplicate license entry
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02