Bug 35584 - Missing licenses in about page
Summary: Missing licenses in about page
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 34900
Blocks: 34623 35633 35638 35640 35642 35643
  Show dependency treegraph
 
Reported: 2023-12-15 20:33 UTC by Victor Grousset/tuxayo
Modified: 2024-01-15 14:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02


Attachments
Bug 35584: Add missing licenses to about page (11.95 KB, patch)
2023-12-20 13:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35584: Add missing licenses to about page (12.00 KB, patch)
2023-12-20 20:16 UTC, David Nind
Details | Diff | Splinter Review
Bug 35584: (follow-up) Add license information and fix sort order (5.48 KB, patch)
2023-12-20 20:16 UTC, David Nind
Details | Diff | Splinter Review
Bug 35584: Add missing licenses to about page (12.05 KB, patch)
2023-12-22 12:37 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35584: (follow-up) Add license information and fix sort order (5.54 KB, patch)
2023-12-22 12:37 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35584: (QA Follow-up): (3.48 KB, patch)
2023-12-22 12:37 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35584: Add missing licenses to about page (12.06 KB, patch)
2024-01-04 12:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35584: (follow-up) Add license information and fix sort order (5.54 KB, patch)
2024-01-04 12:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35584: (QA follow-up): (3.48 KB, patch)
2024-01-04 12:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35584: (follow-up) Remove duplicate license entry (1.56 KB, patch)
2024-01-08 17:02 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2023-12-15 20:33:57 UTC
Thanks David Nind for noticing it in Bug 34900

> I've just had a quick look (not comprehensive), and it looks like there are
> some software licences missing, including:
> - DataTables (koha-tmpl/intranet-tmpl/lib/datatables)
> - GreyBox (koha-tmpl/intranet-tmpl/lib/greybox)
> - Some jQuery plugins - jsTree, rowGroup (doesn't look the same as
> jquery.dataTables.grouping.js), fnReloadAjax (part of DataTables?),
> Humanized Messages, jquery.dataTables.columnFilter.js (part of DataTables?),
> highlight (part of DataTables?), jquery-jeditable
> (koha-tmpl/intranet-tmpl/lib/jquery/plugins/)
> - linters (several) (koha-tmpl/intranet-tmpl/lib/linters)
> - sortable (koha-tmpl/intranet-tmpl/lib/linters/sortable)
> - vis-timeline and vis-graph2d (koha-tmpl/intranet-tmpl/lib/vis-timeline/)
> - media.match.js (koha-tmpl/opac-tmpl/lib/)
Comment 1 Owen Leonard 2023-12-20 13:10:13 UTC
Created attachment 160116 [details] [review]
Bug 35584: Add missing licenses to about page

This patch adds license information to the about page which was missing
for several JavaScript libraries. The patch also makes a minor change to
CSS to improve alignment of content in the licenses tab.

One library, vis-timeline-graph2d.min.js, lacked the correct version
information in the source. This information has been added.

To test, apply the patch and rebuild the staff interface CSS.

- Go to the about page and open the "Licenses" tab.
- Confirm that the information looks correct.
Comment 2 David Nind 2023-12-20 20:16:49 UTC
Created attachment 160162 [details] [review]
Bug 35584: Add missing licenses to about page

This patch adds license information to the about page which was missing
for several JavaScript libraries. The patch also makes a minor change to
CSS to improve alignment of content in the licenses tab.

One library, vis-timeline-graph2d.min.js, lacked the correct version
information in the source. This information has been added.

To test, apply the patch and rebuild the staff interface CSS.

- Go to the about page and open the "Licenses" tab.
- Confirm that the information looks correct.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-12-20 20:16:51 UTC
Created attachment 160163 [details] [review]
Bug 35584: (follow-up) Add license information and fix sort order

Add license information and links. Put in alphabetical order.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-12-20 20:17:30 UTC
Thanks Owen!
Comment 5 Pedro Amorim 2023-12-22 12:37:23 UTC
Created attachment 160231 [details] [review]
Bug 35584: Add missing licenses to about page

This patch adds license information to the about page which was missing
for several JavaScript libraries. The patch also makes a minor change to
CSS to improve alignment of content in the licenses tab.

One library, vis-timeline-graph2d.min.js, lacked the correct version
information in the source. This information has been added.

To test, apply the patch and rebuild the staff interface CSS.

- Go to the about page and open the "Licenses" tab.
- Confirm that the information looks correct.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 6 Pedro Amorim 2023-12-22 12:37:25 UTC
Created attachment 160232 [details] [review]
Bug 35584: (follow-up) Add license information and fix sort order

Add license information and links. Put in alphabetical order.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 7 Pedro Amorim 2023-12-22 12:37:28 UTC
Created attachment 160233 [details] [review]
Bug 35584: (QA Follow-up):

Typo fix: GreBox -> Greybox
Capitalization fix: JavaScript case
Order to match header fix: jsTree jQuery -> jQuery jsTree
Capitalization fix: treetable -> Treetable capitalization

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 8 Katrin Fischer 2023-12-27 16:33:00 UTC
The dependency here is still "NSO" and the last patch here should have a proper description please :)
Comment 9 Jonathan Druart 2024-01-04 12:43:15 UTC
Created attachment 160526 [details] [review]
Bug 35584: Add missing licenses to about page

This patch adds license information to the about page which was missing
for several JavaScript libraries. The patch also makes a minor change to
CSS to improve alignment of content in the licenses tab.

One library, vis-timeline-graph2d.min.js, lacked the correct version
information in the source. This information has been added.

To test, apply the patch and rebuild the staff interface CSS.

- Go to the about page and open the "Licenses" tab.
- Confirm that the information looks correct.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 10 Jonathan Druart 2024-01-04 12:43:17 UTC
Created attachment 160527 [details] [review]
Bug 35584: (follow-up) Add license information and fix sort order

Add license information and links. Put in alphabetical order.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 11 Jonathan Druart 2024-01-04 12:43:20 UTC
Created attachment 160528 [details] [review]
Bug 35584: (QA follow-up):

Typo fix: GreBox -> Greybox
Capitalization fix: JavaScript case
Order to match header fix: jsTree jQuery -> jQuery jsTree
Capitalization fix: treetable -> Treetable capitalization

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 12 Katrin Fischer 2024-01-04 15:44:27 UTC
It looks like a double up:

jQuery UI Virtual Keyboard
Virtual Keyboard

Same version and link?
Comment 13 Owen Leonard 2024-01-08 17:02:15 UTC
Created attachment 160653 [details] [review]
Bug 35584: (follow-up) Remove duplicate license entry
Comment 14 Katrin Fischer 2024-01-11 11:12:03 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 15 Fridolin Somers 2024-01-15 14:02:17 UTC
Pushed to 23.11.x for 23.11.02