Description
Lucas Gass (lukeg)
2023-09-07 01:51:33 UTC
Created attachment 155283 [details] [review] Bug 34735: Style disabled breadcrumbs To test: 1. Turn on ERMModule. 2. Notice the disbaled breadcrumbs are color: #000; 3. Apply patch, yarn build 4. Look again, disbaled breadcrumbs are color; #696969; Created attachment 155287 [details] [review] Bug 34735: Remove pointer events from disabled links Add pointer-events: none to a.disabled links in staff Created attachment 155288 [details] [review] Bug 34735: Update breadcrumb markup Make the breadcrumb navigation item markup match the rest of Koha Created attachment 155289 [details] [review] Bug 34735: Remove uneeded CSS (In reply to Lucas Gass from comment #0) > If you look at the breadcrumb describing the current page you are on it is > typically a light grey. In the ERM module those same breadcrumbs are black. I submitted a couple of follow-ups that should make the breadcrumbs mark up in line with the rest of Koha, and inherit the styling that way. Lucas, please take a look and see if you agree with my patches, or make them obsolete if not. Thanks. Created attachment 155303 [details] [review] Bug 34735: Style disabled breadcrumbs To test: 1. Turn on ERMModule. 2. Notice the disbaled breadcrumbs are color: #000; 3. Apply patch, yarn build 4. Look again, disbaled breadcrumbs are color; #696969; Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 155304 [details] [review] Bug 34735: Remove pointer events from disabled links Add pointer-events: none to a.disabled links in staff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 155305 [details] [review] Bug 34735: Update breadcrumb markup Make the breadcrumb navigation item markup match the rest of Koha Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 155306 [details] [review] Bug 34735: Remove uneeded CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Pedro Amorim from comment #5) > (In reply to Lucas Gass from comment #0) > > If you look at the breadcrumb describing the current page you are on it is > > typically a light grey. In the ERM module those same breadcrumbs are black. > > I submitted a couple of follow-ups that should make the breadcrumbs mark up > in line with the rest of Koha, and inherit the styling that way. > > Lucas, please take a look and see if you agree with my patches, or make them > obsolete if not. > > Thanks. Thanks Pedro! Looks good. Created attachment 155746 [details] [review] Bug 34735: Style disabled breadcrumbs To test: 1. Turn on ERMModule. 2. Notice the disbaled breadcrumbs are color: #000; 3. Apply patch, yarn build 4. Look again, disbaled breadcrumbs are color; #696969; Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 155747 [details] [review] Bug 34735: Remove pointer events from disabled links Add pointer-events: none to a.disabled links in staff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 155748 [details] [review] Bug 34735: Update breadcrumb markup Make the breadcrumb navigation item markup match the rest of Koha Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 155749 [details] [review] Bug 34735: Remove uneeded CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> It actually matches the behaviour we have in the navmenu. Why is this better than before? Ok nevermind, looks good now after a second look. Pushed to master for 23.11. Nice work everyone, thanks! Depends on Bug 33169 not in 23.05.x (In reply to Fridolin Somers from comment #18) > Depends on Bug 33169 not in 23.05.x In the end Bug 33169 has been backported. Do you advice to backport this one ? |