Bug 34735 - Current/disabled links in breadcrumbs are styled differently when in ERM module
Summary: Current/disabled links in breadcrumbs are styled differently when in ERM module
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 33169
Blocks:
  Show dependency treegraph
 
Reported: 2023-09-07 01:51 UTC by Lucas Gass
Modified: 2023-11-02 21:32 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34735: Style disabled breadcrumbs (1019 bytes, patch)
2023-09-07 01:55 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34735: Remove pointer events from disabled links (802 bytes, patch)
2023-09-07 09:56 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34735: Update breadcrumb markup (1.37 KB, patch)
2023-09-07 09:56 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34735: Remove uneeded CSS (851 bytes, patch)
2023-09-07 09:56 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34735: Style disabled breadcrumbs (1.04 KB, patch)
2023-09-07 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34735: Remove pointer events from disabled links (853 bytes, patch)
2023-09-07 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34735: Update breadcrumb markup (1.42 KB, patch)
2023-09-07 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34735: Remove uneeded CSS (901 bytes, patch)
2023-09-07 14:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34735: Style disabled breadcrumbs (1.10 KB, patch)
2023-09-17 13:07 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34735: Remove pointer events from disabled links (910 bytes, patch)
2023-09-17 13:07 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34735: Update breadcrumb markup (1.47 KB, patch)
2023-09-17 13:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34735: Remove uneeded CSS (958 bytes, patch)
2023-09-17 13:08 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-09-07 01:51:33 UTC
If you look at the breadcrumb describing the current page you are on it is typically a light grey. In the ERM module those same breadcrumbs are black.
Comment 1 Lucas Gass 2023-09-07 01:55:22 UTC
Created attachment 155283 [details] [review]
Bug 34735: Style disabled breadcrumbs

To test:
1. Turn on ERMModule.
2. Notice the disbaled breadcrumbs are color: #000;
3. Apply patch, yarn build
4. Look again, disbaled breadcrumbs are color; #696969;
Comment 2 Pedro Amorim 2023-09-07 09:56:20 UTC
Created attachment 155287 [details] [review]
Bug 34735: Remove pointer events from disabled links

Add pointer-events: none to a.disabled links in staff
Comment 3 Pedro Amorim 2023-09-07 09:56:22 UTC
Created attachment 155288 [details] [review]
Bug 34735: Update breadcrumb markup

Make the breadcrumb navigation item markup match the rest of Koha
Comment 4 Pedro Amorim 2023-09-07 09:56:25 UTC
Created attachment 155289 [details] [review]
Bug 34735: Remove uneeded CSS
Comment 5 Pedro Amorim 2023-09-07 09:58:26 UTC
(In reply to Lucas Gass from comment #0)
> If you look at the breadcrumb describing the current page you are on it is
> typically a light grey. In the ERM module those same breadcrumbs are black.

I submitted a couple of follow-ups that should make the breadcrumbs mark up in line with the rest of Koha, and inherit the styling that way.

Lucas, please take a look and see if you agree with my patches, or make them obsolete if not.

Thanks.
Comment 6 Owen Leonard 2023-09-07 14:27:38 UTC
Created attachment 155303 [details] [review]
Bug 34735: Style disabled breadcrumbs

To test:
1. Turn on ERMModule.
2. Notice the disbaled breadcrumbs are color: #000;
3. Apply patch, yarn build
4. Look again, disbaled breadcrumbs are color; #696969;

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Owen Leonard 2023-09-07 14:27:41 UTC
Created attachment 155304 [details] [review]
Bug 34735: Remove pointer events from disabled links

Add pointer-events: none to a.disabled links in staff

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 8 Owen Leonard 2023-09-07 14:27:43 UTC
Created attachment 155305 [details] [review]
Bug 34735: Update breadcrumb markup

Make the breadcrumb navigation item markup match the rest of Koha

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Owen Leonard 2023-09-07 14:27:45 UTC
Created attachment 155306 [details] [review]
Bug 34735: Remove uneeded CSS

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 10 Lucas Gass 2023-09-07 14:34:36 UTC
(In reply to Pedro Amorim from comment #5)
> (In reply to Lucas Gass from comment #0)
> > If you look at the breadcrumb describing the current page you are on it is
> > typically a light grey. In the ERM module those same breadcrumbs are black.
> 
> I submitted a couple of follow-ups that should make the breadcrumbs mark up
> in line with the rest of Koha, and inherit the styling that way.
> 
> Lucas, please take a look and see if you agree with my patches, or make them
> obsolete if not.
> 
> Thanks.

Thanks Pedro! Looks good.
Comment 11 Katrin Fischer 2023-09-17 13:07:54 UTC
Created attachment 155746 [details] [review]
Bug 34735: Style disabled breadcrumbs

To test:
1. Turn on ERMModule.
2. Notice the disbaled breadcrumbs are color: #000;
3. Apply patch, yarn build
4. Look again, disbaled breadcrumbs are color; #696969;

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2023-09-17 13:07:57 UTC
Created attachment 155747 [details] [review]
Bug 34735: Remove pointer events from disabled links

Add pointer-events: none to a.disabled links in staff

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Katrin Fischer 2023-09-17 13:08:00 UTC
Created attachment 155748 [details] [review]
Bug 34735: Update breadcrumb markup

Make the breadcrumb navigation item markup match the rest of Koha

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Katrin Fischer 2023-09-17 13:08:04 UTC
Created attachment 155749 [details] [review]
Bug 34735: Remove uneeded CSS

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 15 Jonathan Druart 2023-09-18 07:08:55 UTC
It actually matches the behaviour we have in the navmenu. Why is this better than before?
Comment 16 Jonathan Druart 2023-09-18 07:15:28 UTC
Ok nevermind, looks good now after a second look.
Comment 17 Tomás Cohen Arazi 2023-09-18 15:04:30 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 18 Fridolin Somers 2023-09-18 20:10:34 UTC
Depends on Bug 33169 not in 23.05.x
Comment 19 Fridolin Somers 2023-11-02 21:32:53 UTC
(In reply to Fridolin Somers from comment #18)
> Depends on Bug 33169 not in 23.05.x

In the end Bug 33169 has been backported.
Do you advice to backport this one ?