Bug 34748

Summary: Wrong column name basket_number in table settings for basket
Product: Koha Reporter: Noémie Labine <noemie.labine>
Component: System AdministrationAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, gmcharlt, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.11
Circulation function:
Attachments: Bug 34748: Fix column name in columns configuration for basket table
Bug 34748: Fix column name in columns configuration for basket table
Bug 34748: Fix column name in columns configuration for basket table

Description Noémie Labine 2023-09-08 18:31:08 UTC
In the table settings, under Acquisition table, the first column of the orders table is basket_number.

But in the table, in a basket, this column doesn't show the basket number but the order line. The name of this column should be order_line.
Comment 1 Katrin Fischer 2023-09-19 21:35:40 UTC
Created attachment 155916 [details] [review]
Bug 34748: Fix column name in columns configuration for basket table

The first column was named basket_number, but it's actually the
order_line.

To test:
* Edit column configuration for acquisition > basket
* Make sure to set at least one checkbox for 'basket_number'
* Apply patch, run database update
* Verify that the first column is now 'order_line', but your
  settings have been preserved
Comment 2 David Nind 2023-09-20 01:04:46 UTC
Created attachment 155919 [details] [review]
Bug 34748: Fix column name in columns configuration for basket table

The first column was named basket_number, but it's actually the
order_line.

To test:
* Edit column configuration for acquisition > basket
* Make sure to set at least one checkbox for 'basket_number'
* Apply patch, run database update
* Verify that the first column is now 'order_line', but your
  settings have been preserved

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Noémie Labine 2023-09-20 19:20:10 UTC
I can't seem to properly sign-off the patch, but I tested it on a sandbox and it works.

Thanks you
Comment 4 Marcel de Rooy 2023-09-22 09:05:17 UTC
Created attachment 156041 [details] [review]
Bug 34748: Fix column name in columns configuration for basket table

The first column was named basket_number, but it's actually the
order_line.

To test:
* Edit column configuration for acquisition > basket
* Make sure to set at least one checkbox for 'basket_number'
* Apply patch, run database update
* Verify that the first column is now 'order_line', but your
  settings have been preserved

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-09-25 13:49:38 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-25 19:23:34 UTC
Pushed to 23.05.x for 23.05.04

Maybe depends on Bug 31932
Comment 7 Jacob O'Mara 2023-10-17 11:45:17 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x