The indentation on basket.tt is really confusing and could do with a cleanup.. lots of nested conditions without consistent nesting end points. I'd also love to see the top two col sections marked up with page-section to 'card' them, and we could do with fixing where the 'add user' link appear on the 'Managed by' row. Lots of little things.
Created attachment 145664 [details] [review] Bug 31932: The basket summary page template needs a cleanup This patch reindents the Acquisitions basket template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions. Locate a vendor and add a basket and some orders if necessary. Test as much of the page's functionality as possible, e.g. toolbar controls, in-table controls, managed-by and managing library controls, etc. Try adding an internal note, adding a vendor note, and deleting the basket. Everything should look correct and work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added.
Created attachment 145665 [details] [review] Bug 31932: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality.
Created attachment 145686 [details] [review] Bug 31932: The basket summary page template needs a cleanup This patch reindents the Acquisitions basket template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions. Locate a vendor and add a basket and some orders if necessary. Test as much of the page's functionality as possible, e.g. toolbar controls, in-table controls, managed-by and managing library controls, etc. Try adding an internal note, adding a vendor note, and deleting the basket. Everything should look correct and work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145687 [details] [review] Bug 31932: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Much clearer, thanks for this Owen.. I had meant to come back to it myself but there's never enough time is there! It's much more understandable now. Signing off
Created attachment 145736 [details] [review] Bug 31932: The basket summary page template needs a cleanup This patch reindents the Acquisitions basket template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions. Locate a vendor and add a basket and some orders if necessary. Test as much of the page's functionality as possible, e.g. toolbar controls, in-table controls, managed-by and managing library controls, etc. Try adding an internal note, adding a vendor note, and deleting the basket. Everything should look correct and work correctly. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 145737 [details] [review] Bug 31932: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport